29996 2016-11-10 15:39:08 +0000 RelaxNG EQName definition too loose. 2016-11-16 17:02:22 +0000 1 1 1 Unclassified XPath / XQuery / XSLT XSLT 3.0 Member-only Editors Drafts PC All RESOLVED FIXED P2 minor --- 1 charles mike public-qt-comments oldest_to_newest 128134 0 charles 2016-11-10 15:39:08 +0000 The RelaxNG Schema definition for an EQName is as follows: eqname.datatype = xsd:QName | xsd:token { pattern = "Q\{[^{}]*\}\i\c*|\i\c*:.+" } This type allows values such as "a:b:c", which would be invalid EQNames. 128135 1 charles 2016-11-10 15:49:38 +0000 I suggest replacing the definition of the eqname.datatype from: eqname.datatype = xsd:QName | xsd:token { pattern = "Q\{[^{}]*\}\i\c*|\i\c*:.+" } And instead, use the following: uri.qualified.name = xsd:token { pattern = "Q\{[^\{\}]*\}[\i-[:]][\c-[:]]*" } qname.strict = xsd:token { pattern = "[\i-[:]][\c-[:]]:[\i-[:]][\c-[:]]" } eqname.datatype = xsd:QName | uri.qualified.name | qname.strict This would allow regular QNames, or Qualified names defined by uri.qualified.name, or strict QNames defined by "qname.strict" and will not allow "a:b:c". On applying this locally to the RNC in the test suite, all XSLT tests validate except from "xml-version-025.xsl". The reason why this fails is because Jing (at least the version I have) does not support The RexEx notions of \i and \c correctly. I plan to submit a patch to Jing in order that \i and \c are properly supported, which would result in "xml-version-025.xsl" passing, but for the now at least, I believe the RelaxNG code written above is correct regardless of the Jing RelaxNG implementation failing to validate a correct XSLT file. 128137 2 charles 2016-11-10 17:56:05 +0000 This was discussed on the Telcon (2016-11-10). Michael Kay asked why the RegEx is not the same as the one in the XSD. Abel Braaksma explained that the XSD benefits from inheritance of patterns, which is different in this case. Everybody seems to agree with the proposed update in comment 1. I will push this change to the test suite and notify MK. 128186 3 mike 2016-11-16 17:02:22 +0000 The updated schema has been committed.