29612 2016-05-06 09:27:23 +0000 [FO31] Function argument naming 2016-07-21 14:58:04 +0000 1 1 1 Unclassified XPath / XQuery / XSLT Functions and Operators 3.1 Candidate Recommendation PC Windows NT CLOSED FIXED P2 editorial --- 1 tim mike public-qt-comments oldest_to_newest 126357 0 tim 2016-05-06 09:27:23 +0000 Looking at the *:for-each functions, it would be nice if the applied function had a consistent name. array:for-each( $array as array(*), $function as function(item()*) as item()*) as array(*) map:for-each( $input as map(*), $action as function(xs:anyAtomicType, item()*)) as item()* fn:for-each($seq as item()*, $f as function(item()) as item()*) as item()* 126359 1 tim 2016-05-06 09:32:05 +0000 It would also be nice if array:for-each and map:for-each had matching or consistent names for the first argument. e.g. array:for-each( $input as array(*), $action as function(item()*) as item()*) as array(*) map:for-each( $input as map(*), $action as function(xs:anyAtomicType, item()*)) as item()* or array:for-each( $array as array(*), $action as function(item()*) as item()*) as array(*) map:for-each( $map as map(*), $action as function(xs:anyAtomicType, item()*)) as item()* 126678 2 mike 2016-06-06 15:21:03 +0000 I have changed map:keys(), map:size(), and map:for-each() to use $map as the name of the first argument. I have changed map:for-each(), array:for-each(), fn:for-each(), and fn:for-each-pair() to use $action as the name of the function argument. Note: I'm not sure these changes at this stage are really a good idea. There is a grave danger of introducing unnecessary errors, and I'm not at all convinced we should be encouraging readers to think of the argument names as being in any way significant.