29547 2016-03-30 18:16:44 +0000 Castable tests assume no year zero 2016-10-24 21:09:14 +0000 1 1 1 Unclassified XPath / XQuery / XSLT XQuery 3 & XPath 3 Test Suite Candidate Recommendation PC All RESOLVED FIXED P2 normal --- 1 mike oneil andrew_coleman benito public-qt-comments oldest_to_newest 125672 0 mike 2016-03-30 18:16:44 +0000 In prod-CastableExpr, tests cbcl-castable-gYear-002 cbcl-castable-gYear-003 cbcl-castable-gYearMonth-003 cbcl-castable-gYearMonth-004 assume year zero is not allowed. This is true of XSD 1.0 but not of XSD 1.1 But the tests have no dependency on XSD version. 125908 1 oneil 2016-04-19 10:03:48 +0000 I am suggesting that we split these tests into two: One for XSD 1.0 and the other for XSD 1.1. I will make the change. 125910 2 oneil 2016-04-19 10:14:05 +0000 See also the bug #29576 which suggests a minimum and maximum year that all implementations must support. 126404 3 oneil 2016-05-10 15:13:51 +0000 Bug fixed according to the resolution: make these tests (a) dependent on support for XSD 1.1, and (b) allow an FODT0001 result for implementations whose minimum year is 0001. 126455 4 benito 2016-05-17 21:06:12 +0000 That would affect these tests, too: ? cbcl-cast-gYear-002: "0000" cast as xs:gYear cbcl-cast-gYearMonth-003: "0000-05" cast as xs:gYearMonth 126456 5 benito 2016-05-17 21:12:10 +0000 And cbcl-cast-gYear-003: "-0000" cast as xs:gYear cbcl-cast-gYearMonth-004: "-0000-05" cast as xs:gYearMonth ? 127425 6 oneil 2016-09-20 09:41:32 +0000 (In reply to Benito van der Zander from comment #5) > And > > cbcl-cast-gYear-003: "-0000" cast as xs:gYear > cbcl-cast-gYearMonth-004: "-0000-05" cast as xs:gYearMonth > > > ? I have committed a fix for these test cases. 127660 7 mike 2016-10-05 12:04:01 +0000 I don't understand the change that was made to these tests: > cbcl-cast-gYear-003: "-0000" cast as xs:gYear > cbcl-cast-gYearMonth-004: "-0000-05" cast as xs:gYearMonth Previously the tests had no XSD dependency, and were expected to fail FORG0001, which I think was correct: year zero is not valid under XSD 1.0. Now the tests have been changed to have a dependency on XSD 1.1. I think this makes the cast succeed. But the expected results have been changed to allow a choice of errors: FORG0001 or FODT0001. I think there should be two versions of each of these two tests: (a) an XSD 1.0 version which expects FORG0001 (b) an XSD 1.1 version which expects either success, or FODT0001. 127894 8 andrew_coleman 2016-10-21 07:22:01 +0000 The WG agreed the following resolution: ACTION A-657-19: O'Neil to look at tests cbcl-cast-gYear-003 and cbcl-cast-gYearMonth-004 and to fix as proposed by MKay in comment #7 of bug 29547 (drop errors as allowed result) 127944 9 oneil 2016-10-24 16:08:14 +0000 Bug fixed accordingly to comment 7 and 8 127946 10 benito 2016-10-24 21:09:14 +0000 Now there are still cbcl-cast-gYear-002, cbcl-cast-gYearMonth-003 and cbcl-cast-gYearMonth-004 running with xsd 1.1 and only accepting FORG0001/FODT0001