29418 2016-02-04 12:21:34 +0000 PlatformObjectGetOwnProperty's ignoreNamedProps feature 2016-02-04 14:43:55 +0000 1 1 1 Unclassified WebAppsWG WebIDL unspecified PC All RESOLVED WORKSFORME P2 normal --- 1 annevk cam bzbarsky mike public-script-coord public-webapps-bugzilla oldest_to_newest 124830 0 annevk 2016-02-04 12:21:34 +0000 Is there any class that supports indexed getters that also has a member that could be mistaken for an indexed getter? Because that seems to be the only reason why we wouldn't return a property descriptor for undefined here. And the fact that we don't return a property descriptor for undefined here actually creates a bug for the Window object, since its named properties are looked up in a different algorithm on a different object. Having said that, this bug will go away since we'll most likely move indexed property lookup to the window proxy object so the Window object can become an "ordinary" object. 124833 1 bzbarsky 2016-02-04 14:30:32 +0000 > Because that seems to be the only reason why we wouldn't return a property > descriptor for undefined here. You mean at the point where we set ignoreNamedProps to true in http://heycam.github.io/webidl/#getownproperty-guts step 1.3? It's possible that this predates the change to make [[DefineOwnProperty]] just disallow adding indexed-looking props, assuming it ever allowed it. So back then you could have expandos with integer names and those were supposed to get picked up via step 3. That said, I guess someone _could_ in theory define an unforgeable thing named "_1" (in the IDL) on an interface with indexed props. That seems silly and we should not support it. So I think you're right that we could just return here if we wanted to, though it should be equivalent to fall through, since we know step 3 won't find anything. Note that we do still need the ignoreNamedProps thing in general, for [[Set]] to work right. 124836 2 annevk 2016-02-04 14:43:55 +0000 Given that [[Set]] needs this setting the variable there is actually shorter than returning the correct property descriptor.