<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>29391</bug_id>
          
          <creation_ts>2016-01-25 19:36:25 +0000</creation_ts>
          <short_desc>Pattern-toolbar</short_desc>
          <delta_ts>2016-03-11 17:31:59 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>ARIA</product>
          <component>Practices</component>
          <version>Future</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows NT</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://rawgit.com/w3c/aria/apg-toolbar/practices/aria-practices.html#toolbar</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt King">a11ythinker</reporter>
          <assigned_to name="Matt King">a11ythinker</assigned_to>
          <cc>w3cbugzilla</cc>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>124709</commentid>
    <comment_count>0</comment_count>
    <who name="Matt King">a11ythinker</who>
    <bug_when>2016-01-25 19:36:25 +0000</bug_when>
    <thetext>Rewrite description to be more inline with spec; remove compact visual form language.
Delete references to menu/menubar.
delete sentence about using role group for a bunch of toolbars.
In keyboard interaction, remove:
&quot;Direction may need to be adjusted for Right to Left languages &quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125057</commentid>
    <comment_count>1</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-15 18:32:01 +0000</bug_when>
    <thetext>* Make sure the language doesn&apos;t assume controls are buttons.
(i.e. change Tab moves focus to the first enabled toolbar button. &amp; Left Arrow and Right Arrow keys navigate to the enabled buttons in the toolbar)

* Add some language about elements which consume left/right arrow in the toolbar. Something about &quot;avoid them&quot; but if really have to add them then add ways to mitigate their usage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125059</commentid>
    <comment_count>2</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-15 18:35:32 +0000</bug_when>
    <thetext>* Change text about shortcut keystroke to talk about &quot;application level toolbar&quot; or toolbar &quot;relevant to current context&quot;. We should not encourage unique keystrokes to every toolbar in the page.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125061</commentid>
    <comment_count>3</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-15 18:49:33 +0000</bug_when>
    <thetext>Disabled element discussion:
&quot;In general disabled elements are not included in the focus sequence but there may be some circumstances where discoverability of a function is crucial and an author may choose to include them in the navigation sequence.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125062</commentid>
    <comment_count>4</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-15 18:52:02 +0000</bug_when>
    <thetext>(delete the rest of the conversation about disabled buttons)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125063</commentid>
    <comment_count>5</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-15 19:00:49 +0000</bug_when>
    <thetext>WAI-ARIA Roles, States, and Properties:
Delete - 
* The children of the toolbar are frequently elements with role button.
* Other tools that are common within toolbars are comboboxes and pull-down menus.

Modify 
* It is recommended that a toolbar is labelled using aria-label.

To
* It is recommended that a toolbar is labelled especially if there is more than 1 toolbar</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125204</commentid>
    <comment_count>6</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-22 18:12:53 +0000</bug_when>
    <thetext>Keyboard Interaction Section.

Change first bullet to

* The listbox element is focusable. See Keyboard Navigation between Widgets.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125205</commentid>
    <comment_count>7</comment_count>
    <who name="James Nurthen">w3cbugzilla</who>
    <bug_when>2016-02-22 18:14:22 +0000</bug_when>
    <thetext>(In reply to James Nurthen from comment #6)
&gt; Keyboard Interaction Section.
&gt; 
&gt; Change first bullet to
&gt; 
&gt; * The listbox element is focusable. See Keyboard Navigation between Widgets.

Please ignore this comment. Wrong bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125377</commentid>
    <comment_count>8</comment_count>
    <who name="Matt King">a11ythinker</who>
    <bug_when>2016-03-07 18:53:40 +0000</bug_when>
    <thetext>Add orientation and kb information for orientation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>125446</commentid>
    <comment_count>9</comment_count>
    <who name="Matt King">a11ythinker</who>
    <bug_when>2016-03-11 17:31:59 +0000</bug_when>
    <thetext>All changes complete and merged into master.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>