29259 2015-11-03 18:37:36 +0000 [QT3TS] subarray() errorcode for test d1e76078 2015-12-03 17:29:46 +0000 1 1 1 Unclassified XPath / XQuery / XSLT Functions and Operators 3.1 Working drafts PC All CLOSED FIXED P2 normal --- 1 debbie mike andrew_coleman debbie public-qt-comments oldest_to_newest 124064 0 debbie 2015-11-03 18:37:36 +0000 The expected error code for the test d1e76078 in test set app-Walmsley has been modified. The test is: declare variable $array1 := ["abc","def","ghi","jkl"]; array:subarray($array1,6) And now expects FOAY0001, rather than FOAY0002. From a strict reading of the spec, I disagree with the change. The spec currently says "raise [err:FOAY0001] if $start is less than one"; but it does not say raise this error if $start is greater than array:size($array) (perhaps this is a spec bug??). It says "The two-argument version of the function returns the same result (or the same error) as the three-argument version when called with $length equal to the value of array:size($array) - $start + 1." So in this case, $length is calculated to be -1, and then we get "raise [err:FOAY0002] if $length is less than zero." 124327 1 andrew_coleman 2015-12-01 16:35:15 +0000 The WG decided to treat this as a bug against F&O spec 124342 2 mike 2015-12-02 16:11:28 +0000 The WG made some disapproving noises about the fact that the test had been changed without consultation. The WG decided to change the specification of array:subarray() so that FOAY0001 is raised in this case, as expected by the revised test. The specification has been changed accordingly, and the test results stand. 124357 3 debbie 2015-12-03 17:20:23 +0000 Typo in the spec change. In the amended line: A dynamic error is raised [err:FOAY0001] if $start is less than one or greater than array:size($array) + 1. The final "+ 1" is incorrect, it should just be "...or greater than array:size($array)." 124358 4 debbie 2015-12-03 17:25:55 +0000 Sorry, ignore my last comment; the change is correct. $start is allowed to be array:size($array) + 1 to return an empty array.