2920 2006-02-22 22:35:15 +0000 Several invalid forms using @charset passed as valid 2008-03-08 00:02:20 +0000 1 1 1 Unclassified CSSValidator CSS 2.0 CSS Validator PC Windows XP RESOLVED FIXED http 404 Fichier non trouv P2 normal --- 1 cecil dave.null www-validator-cvs oldest_to_newest 8390 0 cecil 2006-02-22 22:35:15 +0000 The CSS validator passes the following with no error, Test case 1. @charset"utf-8"; (spec requires a space before open quotes) Test case 2. @charset "utf-8"; (spec requires exactly 1 space before opening double quotes) Test case 3. @charset "utf-8"; (newline instead of space) Test case 4. @charset/**/"utf-8"; Test case 5. @charset "utf-8" ; (illegal space before semicolon) Test case 6. @charset "utf-8" ; (illegal newline before semicolon) Test case 7: /**/@charset "utf-8"; Regards, Cecil Ward. 8395 1 bjoern 2006-02-23 04:52:12 +0000 I assume with "the spec" you mean the CSS 2.1 Working Draft? CSS 2.1 changed the rules for this and the CSS Validator predates those draft rules... 9389 2 cecil 2006-04-21 15:40:55 +0000 (In reply to comment #1) > I assume with "the spec" you mean the CSS 2.1 Working Draft? CSS 2.1 changed > the rules for this and the CSS Validator predates those draft rules... Good point. Indeed, I was looking at CSS 2.1. But my point stands, because even if you explicitly set the validator to use CSS 2.1, it passes all the above. (I just rechecked.) So it basically can not validate against the 2.1 grammar. As for CSS2.0 (if you like0, I would need to look at the test cases again with CSS2.0 eyes. But presumably having something that is valid only against CSS2.0 but is not actually going to work in (any? some?) browsers isn't useful. Maybe the validator should issue a warning about certain highly questionable forms of css if the user explicitly selects CSS2.0. A further point. If the user has not specified a version of CSS, and the various grammars are in conflict, in the sense that what the user has entered is legal in one version of CSS but illegal in another, then maybe the best thing to do would be to warn the user rather than just saying "valid!" which is meaningless and sort-of dangerous. Suggestion: In the case where the user does not pick as CSS version one possible improvement would be to parse the user's CSS fragment multiple times against the various grammars and if there are both passes and fails, tell the user the details. Warnings about lack of backwards- or forwards capability would be a valuable added benefit of using the validator. 9393 3 cecil 2006-04-21 17:23:18 +0000 Having taken another look, from a CSS2.0 standpoint CSS 2 section 4.4 states "@charset rule [...] must appear at the very start of the document, not preceded by any characters". So by this paragraph, the validator should report an error in the case where some whitespace and/or a comment, say, precedes the @charset. This is a fault. Because of the restrictive specification of @charset, the CSS validator is not at liberty to pre-strip all comments or strip whitespace in an initial phase before doing futher syntactical analysis. Looking at the output displayed in the case of an error suggests that it may pre-strip comments. As for the CSS2 documents, the restriction expressed in that English sentence is not reflected in the example formal grammar in the CSS2 appendix D, which is too lax. 13707 4 ot 2007-01-19 03:40:39 +0000 (removing spam) 17364 5 cecil 2007-10-23 21:26:50 +0000 As far as I can see all of the above test cases 1-7 are now fixed. We can close this. However, in for example, test case 1 now correctly reports failure, apart from if CSS1 is selected, when it seems to fall over (error message looks strange). Some of the other test cases produce the same weird error if CSS1 is selected. I haven't gone through them all (yet). 19361 6 528 ot 2008-03-07 23:23:28 +0000 Created attachment 528 test case 1 19362 7 529 ot 2008-03-07 23:23:49 +0000 Created attachment 529 test case 2 19363 8 530 ot 2008-03-07 23:24:13 +0000 Created attachment 530 test case 3 19364 9 531 ot 2008-03-07 23:24:35 +0000 Created attachment 531 test case 4 19365 10 532 ot 2008-03-07 23:24:52 +0000 Created attachment 532 test case 5 19366 11 533 ot 2008-03-07 23:25:17 +0000 Created attachment 533 test case 6 19367 12 534 ot 2008-03-07 23:25:43 +0000 Created attachment 534 test case 7 19368 13 ot 2008-03-08 00:02:20 +0000 Thanks Cecil for the test cases. I added them into the test suite to make sure we don't have any regression in the future. 528 2008-03-07 23:23:28 +0000 2008-03-07 23:23:28 +0000 test case 1 2920-1.css text/css 108 ot QGNoYXJzZXQidXRmLTgiOwpwIHsKICAgIGZvbnQtZmFtaWx5OiAi44OS44Op44Ku44OO6KeS44K0 IFBybyBXMyIsICJIaXJhZ2lubyBLYWt1IEdvdGhpYyBQcm8iLCBzYW5zLXNlcmlmOwp9 529 2008-03-07 23:23:49 +0000 2008-03-07 23:23:49 +0000 test case 2 2920-2.css text/css 122 ot QGNoYXJzZXQgICAgICAgICAgICAgICJ1dGYtOCI7CnAgewogICAgZm9udC1mYW1pbHk6ICLjg5Lj g6njgq7jg47op5LjgrQgUHJvIFczIiwgIkhpcmFnaW5vIEtha3UgR290aGljIFBybyIsIHNhbnMt c2VyaWY7Cn0= 530 2008-03-07 23:24:13 +0000 2008-03-07 23:24:13 +0000 test case 3 2920-3.css text/css 109 ot QGNoYXJzZXQKInV0Zi04IjsKcCB7CiAgICBmb250LWZhbWlseTogIuODkuODqeOCruODjuinkuOC tCBQcm8gVzMiLCAiSGlyYWdpbm8gS2FrdSBHb3RoaWMgUHJvIiwgc2Fucy1zZXJpZjsKfQ== 531 2008-03-07 23:24:35 +0000 2008-03-07 23:24:35 +0000 test case 4 2920-4.css text/css 112 ot QGNoYXJzZXQvKiovInV0Zi04IjsKcCB7CiAgICBmb250LWZhbWlseTogIuODkuODqeOCruODjuin kuOCtCBQcm8gVzMiLCAiSGlyYWdpbm8gS2FrdSBHb3RoaWMgUHJvIiwgc2Fucy1zZXJpZjsKfQ== 532 2008-03-07 23:24:52 +0000 2008-03-07 23:24:52 +0000 test case 5 2920-5.css text/css 110 ot QGNoYXJzZXQgInV0Zi04IiA7CnAgewogICAgZm9udC1mYW1pbHk6ICLjg5Ljg6njgq7jg47op5Lj grQgUHJvIFczIiwgIkhpcmFnaW5vIEtha3UgR290aGljIFBybyIsIHNhbnMtc2VyaWY7Cn0= 533 2008-03-07 23:25:17 +0000 2008-03-07 23:25:17 +0000 test case 6 2920-6.css text/css 110 ot QGNoYXJzZXQgInV0Zi04Igo7CnAgewogICAgZm9udC1mYW1pbHk6ICLjg5Ljg6njgq7jg47op5Lj grQgUHJvIFczIiwgIkhpcmFnaW5vIEtha3UgR290aGljIFBybyIsIHNhbnMtc2VyaWY7Cn0= 534 2008-03-07 23:25:43 +0000 2008-03-07 23:25:43 +0000 test case 7 2920-7.css text/css 113 ot LyoqL0BjaGFyc2V0ICJ1dGYtOCI7CnAgewogICAgZm9udC1mYW1pbHk6ICLjg5Ljg6njgq7jg47o p5LjgrQgUHJvIFczIiwgIkhpcmFnaW5vIEtha3UgR290aGljIFBybyIsIHNhbnMtc2VyaWY7Cn0=