28737 2015-06-02 06:38:14 +0000 Request to extend importScripts(urls) for ServiceWorkerGlobalScope 2015-09-02 19:02:20 +0000 1 1 1 Unclassified WHATWG HTML unspecified PC Linux RESOLVED FIXED P2 normal Unsorted 1 jungkees ian annevk bkelly d mike contributor oldest_to_newest 120650 0 jungkees 2015-06-02 06:38:14 +0000 Currently service worker monkey patches the importScript(urls) method for its own environment: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#importscripts Incorporating this requirement in HTML would be more accurate. Could you address this? Here's the related discussion: https://github.com/slightlyoff/ServiceWorker/issues/106#issuecomment-51204543 122846 1 annevk 2015-08-28 11:37:06 +0000 Would it not be easier for service workers to define its own method? Domenic's preference is that if they have a distinct implementation they should just be their own methods. 122850 2 d 2015-08-28 12:49:05 +0000 This is kind of tricky though because either the SW importScripts will need to be defined as "like HTML's importScripts, but insert these steps at these positions" or SW will need to copy all the steps from HTML. The former seems fragile to any bugfixes in importScripts, and the latter will get out of date. What do you think of extracting HTML's importScripts definition into a "import scripts in to worker scope" algorithm, which has hooks that can be overridden? The hooks I see needed are: - A validation step, after step 1. In HTML this does nothing. - A generic fetching step, replacing step 5. In HTML this does what step 5 currently does. - A postprocessing step, between steps 6.1 and 6.2. In HTML this does nothing. 122914 3 jungkees 2015-08-31 09:22:35 +0000 I think incorporating the changes directly in HTML would be even better. Is there a reason that's not preferable? If so, I can do what Domenic suggested. FYI. I'd want to make another PR for appcache too: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27482. 122916 4 annevk 2015-08-31 09:43:30 +0000 What Domenic suggests seems good. To be clear, PRs need to be against https://github.com/whatwg/html. Thank you! 123051 5 d 2015-09-02 19:02:20 +0000 https://github.com/whatwg/html/commit/509578d97bd12374e50a409bd4f1ec63cd36a543