28459 2015-04-10 04:45:37 +0000 Algorithm of exitFullscreen() doesn't work correctly when there are nested fullscreen element 2015-07-18 07:21:10 +0000 1 1 1 Unclassified WebAppsWG Fullscreen unspecified All All RESOLVED FIXED P2 normal --- 1 xidorn+w3c annevk mike philipj public-webapps public-webapps-bugzilla oldest_to_newest 119419 0 xidorn+w3c 2015-04-10 04:45:37 +0000 It seems to me that the algorithm fails even on very simple cases. Given the following tree: div#a > div#b and do the following steps: 1. call a.requestFullscreen() 2. call b.requestFullscreen() 3. call document.exitFullscreen() The expected result is, #a, as well as the viewport, is still fullscreen. Is it correct? However, it seems to me that the current spec will cause very strange result. When document.exitFullscreen() is called: In step 4, the "collect ancestors" returns [document] to docs, and since |document| is the topLevelDoc, so in step 6, resize is set to true, which cause the viewport be restored to normal dimensions in step 8. In step 9.1, the "collect ancestors" again returns [document] to docs, and finally in step 9.6, #b is removed from the fullscreen element stack of the document. Finally, #a is still in fullscreen element stack, while the viewport is no longer fullscreen. To fix this, I think we should add a step at the start of "collect ancestors": If fullscreen element stack of doc consists of more than one element, return an empty set. 122060 1 philipj 2015-07-15 12:53:54 +0000 Has this been resolved by the recent refactoring? 122168 2 xidorn+w3c 2015-07-17 02:44:45 +0000 No, it hasn't. The algorithm still doesn't look correct to me. 122171 3 philipj 2015-07-17 07:26:09 +0000 Yeah, you're right. Either collect ancestors should include doc if that has more than a single element in the top layer stack, or the exit fullscreen algorithm needs to handle doc separate somehow. 122205 4 annevk 2015-07-18 07:21:10 +0000 https://github.com/whatwg/fullscreen/commit/67fb879087d646178857fd5fc7312b662b9a8999