28040 2015-02-17 15:00:35 +0000 Comment about canvas high-res outdated? 2016-02-10 14:04:16 +0000 1 1 1 Unclassified WHATWG HTML unspecified Other other RESOLVED MOVED https://html.spec.whatwg.org/#pixel-manipulation [good first bug] P3 normal Unsorted 1 contributor ian annevk mike richarupela95 zcorpan contributor oldest_to_newest 117987 0 contributor 2015-02-17 15:00:35 +0000 Specification: https://html.spec.whatwg.org/multipage/scripting.html Multipage: https://html.spec.whatwg.org/multipage/#pixel-manipulation Complete: https://html.spec.whatwg.org/#pixel-manipulation Referrer: https://html.spec.whatwg.org/multipage/ Comment: Comment about canvas high-res outdated? // notice that we are using input.width and input.height here // as they might not be the same as canvas.width and canvas.height // (in particular, they might be different on high-res displays) Is this correct given https://html5.org/r/8397 ? Posted from: 90.230.218.37 by simonp@opera.com User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.35 Safari/537.36 OPR/28.0.1750.15 (Edition beta) 124953 1 richarupela95 2016-02-10 12:15:11 +0000 hello, could you give some more details for the issue, thanks! 124955 2 annevk 2016-02-10 12:45:49 +0000 I guess the comment could be updated to say something like "In this case, input.width and input.height match canvas.width and canvas.height, but we'll use the former to make the code more generic." 124956 3 richarupela95 2016-02-10 12:59:38 +0000 "In this case we are using, input.width and input.height which match canvas.width and canvas.height, but we'll use the former to make the code more generic." Is this good?(just gave a try) 124957 4 annevk 2016-02-10 13:02:04 +0000 Maybe it's better to keep it simpler: "input.width and input.height happen to match canvas.width and canvas.width, but we'll use the former to keep the code generic." 124958 5 richarupela95 2016-02-10 13:10:50 +0000 okay right, cool. 124959 6 zcorpan 2016-02-10 14:04:16 +0000 https://github.com/whatwg/html/pull/669