27931 2015-01-30 14:27:35 +0000 Override 'flex' and 'transform' styling 2015-03-17 09:45:17 +0000 1 1 1 Unclassified WebAppsWG Fullscreen unspecified PC All RESOLVED FIXED P2 normal --- 1 annevk annevk falken jackalmage mike philipj public-webapps roc zcorpan public-webapps-bugzilla oldest_to_newest 117620 0 annevk 2015-01-30 14:27:35 +0000 The conclusion from https://lists.w3.org/Archives/Public/www-style/2014Nov/thread.html#msg287 seems to be that the rendering section should override 'flex' and 'transform'. Presumably as follows: *|*:not(:root):fullscreen { flex:none !important; transform:none !important; } If anyone disagrees with this now would be a good time to speak up. 117626 1 philipj 2015-01-30 17:22:20 +0000 Sounds great, one less non-standard thing about Chromium's fullscreen support to worry about! 117627 2 philipj 2015-01-30 17:23:17 +0000 https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/css/fullscreen.css 117629 3 philipj 2015-01-30 17:36:48 +0000 So apparently Blink/WebKit have flex:1 !important, from this change: https://trac.webkit.org/changeset/83654 flex:none means 0 0 auto says http://dev.w3.org/csswg/css-flexbox/#flex-property I can't tell from the WebKit bug <https://bugs.webkit.org/show_bug.cgi?id=58291> what the original problematic CSS was. When does flex:1 and flex:none result in different rendering? /me is clueless 117858 4 philipj 2015-02-12 08:51:55 +0000 I've asked Tab to clue us in about flexbox. 118243 5 philipj 2015-03-03 07:09:08 +0000 No reply from Tab. Here's a related Gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1099052 118378 6 philipj 2015-03-06 02:47:56 +0000 In https://codereview.chromium.org/974783002/ I've updated our style sheet to look more like the spec and came to the conclusion that the flex override doesn't matter when the fullscreen element is forced to fill the viewport by other style. What remains, although prefixed, is: :not(:root):fullscreen { transform: none !important; } This should be uncontroversial, so make it so :) 118593 7 jackalmage 2015-03-13 20:55:39 +0000 (In reply to Philip Jägenstedt from comment #5) > No reply from Tab. Here's a related Gecko bug: > https://bugzilla.mozilla.org/show_bug.cgi?id=1099052 Whoops, I missed that email because it came in while I was in Sydney; my email glut afterwards was horrific and still hasn't been fully processed. The flex difference is because the fullscreen element is placed in an anonymous flexbox that fills the screen. "none" means the element stays its natural size, while "1" means it'll stretch to fill the screen if possible (and importantly, *shrink* to fit in the screen if oversized). 118602 8 philipj 2015-03-15 03:55:10 +0000 (In reply to Tab Atkins Jr. from comment #7) > (In reply to Philip Jägenstedt from comment #5) > > No reply from Tab. Here's a related Gecko bug: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1099052 > > Whoops, I missed that email because it came in while I was in Sydney; my > email glut afterwards was horrific and still hasn't been fully processed. > > The flex difference is because the fullscreen element is placed in an > anonymous flexbox that fills the screen. "none" means the element stays its > natural size, while "1" means it'll stretch to fill the screen if possible > (and importantly, *shrink* to fit in the screen if oversized). Does this matter when the fullscreen element is also has !important UA style sheet rules for top, right, bottom, left, width, min-width, max-width, height, min-height and max-height to make it fill the screen? In 10 minutes of tinkering I couldn't find a case where flex could have any influence, but I could very well be mistaken. 118633 9 jackalmage 2015-03-16 23:06:43 +0000 Oh, sorry, I was thinking of <dialog>, not fullscreen. No, there shouldn't be any reason to mess with 'flex' on a fullscreen element. It's not a flex item (being fixpos guarantees that, even if it's a child of a flex container), so 'flex' does nothing at all, regardless of what value it takes. 118641 10 philipj 2015-03-17 02:46:43 +0000 Awesome, thanks Tab! Just to get things going: https://github.com/whatwg/fullscreen/pull/1 118647 11 annevk 2015-03-17 09:45:17 +0000 Thanks Philip! https://github.com/whatwg/fullscreen/commit/a7d0ccf09c9ec01f987856dd9bc99e46a3f33fe2