<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>27920</bug_id>
          
          <creation_ts>2015-01-28 23:27:40 +0000</creation_ts>
          <short_desc>[WebDriver Spec]: takeScreenshot is a GET but what about screenshots of elements??</short_desc>
          <delta_ts>2015-06-10 22:29:12 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>Browser Test/Tools WG</product>
          <component>WebDriver</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>20860</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="David Burns :automatedtester">dburns</reporter>
          <assigned_to name="Browser Testing and Tools WG">public-browser-tools-testing</assigned_to>
          <cc>fisherii</cc>
    
    <cc>james</cc>
    
    <cc>johnjan</cc>
    
    <cc>mike</cc>
    
    <cc>vlotoshnikov</cc>
          
          <qa_contact name="Browser Testing and Tools WG">public-browser-tools-testing</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>117559</commentid>
    <comment_count>0</comment_count>
    <who name="David Burns :automatedtester">dburns</who>
    <bug_when>2015-01-28 23:27:40 +0000</bug_when>
    <thetext>When ripping out webIDL I noticed that in takeScreenshot is a GET which aligns with the OSS Project implementation[1].

We also have the ability now to take screenshots of elements. This will either need to be a POST of the current url endpoint (yuck in my opinion) or a completely new endpoint. I propose we using

GET /session/{sessionId}/screenshot/{ELEMENT}

instead of changing the original call to POST.

Thoughts?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>117560</commentid>
    <comment_count>1</comment_count>
    <who name="Marc Fisher">fisherii</who>
    <bug_when>2015-01-28 23:41:50 +0000</bug_when>
    <thetext>For consistency with other element-level operations I think:

GET /session/{sessionId}/element/{element}/screenshot

makes the most sense as an endpoint.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>117570</commentid>
    <comment_count>2</comment_count>
    <who name="James Graham">james</who>
    <bug_when>2015-01-29 14:51:13 +0000</bug_when>
    <thetext>Yes, I think Marc is correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>117571</commentid>
    <comment_count>3</comment_count>
    <who name="David Burns :automatedtester">dburns</who>
    <bug_when>2015-01-29 15:46:01 +0000</bug_when>
    <thetext>landed in 9cbf052</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>117572</commentid>
    <comment_count>4</comment_count>
    <who name="David Burns :automatedtester">dburns</who>
    <bug_when>2015-01-29 15:52:21 +0000</bug_when>
    <thetext>https://github.com/w3c/webdriver/commit/9cbf052d90a205115347f303b74fc26400bedbc5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>118579</commentid>
    <comment_count>5</comment_count>
    <who name="seva">vlotoshnikov</who>
    <bug_when>2015-03-13 07:13:52 +0000</bug_when>
    <thetext>Spec text still says &apos;Leaving below until Bug 27920 has a consensus&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120893</commentid>
    <comment_count>6</comment_count>
    <who name="John Jansen">johnjan</who>
    <bug_when>2015-06-10 22:06:02 +0000</bug_when>
    <thetext>I do think we have consensus on this, but the spec just needs to change to match it. Marc&apos;s proposal makes a lot of sense.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120894</commentid>
    <comment_count>7</comment_count>
    <who name="James Graham">james</who>
    <bug_when>2015-06-10 22:28:01 +0000</bug_when>
    <thetext>Apart from the fact that the spec text here needs some work, I don&apos;t think there is an actual issue. https://w3c.github.io/webdriver/webdriver-spec.html#element exists.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>120895</commentid>
    <comment_count>8</comment_count>
    <who name="James Graham">james</who>
    <bug_when>2015-06-10 22:29:12 +0000</bug_when>
    <thetext>Oh unless you mean that the URL is still wrong. But it&apos;s just as quick to fix that as discuss it here; I&apos;ll make a PR.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>