27857 2015-01-19 15:31:45 +0000 [MSE] Reorder SourceBuffer.remove() exceptions handling for consistency 2015-02-03 18:58:21 +0000 1 1 1 Unclassified HTML WG Media Source Extensions unspecified PC Linux RESOLVED FIXED P2 normal CR 1 b.gajda acolwell acolwell mike philipj public-html-media public-html-bugzilla oldest_to_newest 117318 0 b.gajda 2015-01-19 15:31:45 +0000 SourceBuffer.remove() 1. If duration equals NaN, then throw an InvalidAccessError exception and abort these steps. 2. If start is negative or greater than duration, then throw an InvalidAccessError exception and abort these steps. 3. If end is less than or equal to start or end equals NaN, then throw an InvalidAccessError exception and abort these steps. 4. If this object has been removed from the sourceBuffers attribute of the parent media source then throw an InvalidStateError exception and abort these steps. 5. If the updating attribute equals true, then throw an InvalidStateError exception and abort these steps. --- I believe this is wrong order, and we move check number 4 (and 5 for consistency) before 1, so the new order would be "4 5 1 2 3" While this might not seem as big deal, any reference to mediaSource data ("duration" in this example) feels wrong if the SourceBuffer is removed from parent MediaSource, and currently check for duration is before check for being removed. This would also be consistent with appendWindowStart, appendWindowEnd, buffered, etc. as they also check first is SB removed. Opinions? Similar but less important issue is with setting mode of SourceBuffer (first InvalidAccess, then InvalidState), but there is no reference to mediaSource data there, so I don't thing it's that big of issue. 117328 1 b.gajda 2015-01-19 18:51:29 +0000 > and we move check number 4 (and 5 for and we *should* move 117674 2 acolwell 2015-02-03 18:58:21 +0000 Change committed... https://github.com/w3c/media-source/commit/ee9ae4ba1681e34b6e90d172759f984ee64ab4c1