27650 2014-12-18 05:55:06 +0000 Add range.insert(nodes...) 2016-08-19 12:23:06 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified All All RESOLVED WONTFIX P2 normal --- 1 hey.hgl annevk crimsteam joris mike www-dom public-webapps-bugzilla oldest_to_newest 116457 0 hey.hgl 2014-12-18 05:55:06 +0000 Since DOM starts to allow multiple nodes to be manipulated in bulk (e.g., node.before, node.after), does it make sense to allow multiple nodes to be inserted into a range as well? For example, range.insertNodes(nodes). Also have a quick question on the algorithm of node.before and likes: The before(nodes) method must run these steps: 1.If the context object does not have a parent, terminate these steps. 2.Run the mutation method macro. 3.Pre-insert node into the context object's parent before the context object. Shouldn't step 3 be something like "For each node in nodes ...", node was never defined in the algorithm. But maybe I missed something. 116461 1 crimsteam 2014-12-18 07:44:50 +0000 (In reply to Glen Huang from comment #0) > Since DOM starts to allow multiple nodes to be manipulated in bulk (e.g., > node.before, node.after), does it make sense to allow multiple nodes to be > inserted into a range as well? > For example, range.insertNodes(nodes). This can be done via range.insertNodes(documentFragment). > The before(nodes) method must run these steps: > > 1.If the context object does not have a parent, terminate these steps. > 2.Run the mutation method macro. > 3.Pre-insert node into the context object's parent before the context object. > > Shouldn't step 3 be something like "For each node in nodes ...", node was > never defined in the algorithm. But maybe I missed something. In step 2. we have "mutation method macro" which make DocumentFragment (when we have more than one node) or node, so this is correct. 116462 2 hey.hgl 2014-12-18 07:53:48 +0000 Ah, that macro, I know I missed something. Thank you. About inserting document fragment into the range, this is exactly what I'm proposing. Instead of asking users to manually create it, DOM should take care of it, much like how it provides sugar like node.append, which is just document fragment + node.appendChild. In this case, range.insertNodes is sugar for document fragment + range.insertNode. 116463 3 crimsteam 2014-12-18 08:09:52 +0000 Or extend insertNode() if it doesn't breake anything: void insertNode((Node or DOMString)... nodes); but the name of the method will be misleading. 116464 4 hey.hgl 2014-12-18 08:16:24 +0000 Or just range.insert(nodes), like node.appendChild -> node.append. 122386 5 joris 2015-08-03 10:16:56 +0000 Why not make DocumentFragment easier to use instead? For example: ``` range.insertNode(new DocumentFragment(node1, 'a text node', node2)); range.insertNode(new DocumentFragment(document.getElementsByClassName('foo'))); range.insertNode([node1, node2]); range.insertNode(new Set([node1, node2])); // iterable ``` This prevents having to change the spec in a lot of places. 127146 6 annevk 2016-08-17 12:05:10 +0000 Do you know if there's any implementer interest for these ideas? And precedence in JavaScript libraries? I'm leaning towards closing this, but you can always open a new issue on GitHub. 127175 7 annevk 2016-08-19 12:23:06 +0000 FWIW, https://github.com/whatwg/dom/issues/new is the new place.