27422 2014-11-24 23:26:01 +0000 Remove CSSCharsetRule? 2015-04-14 11:49:40 +0000 1 1 1 Unclassified CSS CSSOM unspecified PC All RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=438147 https://bugzilla.mozilla.org/show_bug.cgi?id=1148694 P2 normal --- 1 philipj zcorpan public-css-bugzilla oldest_to_newest 115432 0 philipj 2014-11-24 23:26:01 +0000 http://dev.w3.org/csswg/cssom/#csscharsetrule Need a decision to converge on, and the counter makes it seem likely safe to remove: https://www.chromestatus.com/metrics/feature/timeline/popularity/426 115443 1 zcorpan 2014-11-25 09:08:07 +0000 The use counter counts usage of CSSCharsetRule#encoding but compat problems could manifest without using that attribute, e.g. by assuming a certain index for a later rule in cssRules. I recommend removing it in one of the browsers. If it sticks I'll remove it from the spec. 115483 2 philipj 2014-11-25 23:02:12 +0000 You you write a sentence or two why you want to get rid of CSSCharsetRule from the spec, for reference in an Intent to Remove? If you could mark it as at risk or something in the spec that would be nice too. 115486 3 zcorpan 2014-11-25 23:50:18 +0000 http://dev.w3.org/csswg/css-syntax/#charset-rule explains a bit why it doesn't make sense to have it in the object model. Also see http://www.w3.org/mid/op.wxt85uaqidj3kv@simons-macbook-pro.local * @charset is a syntax construct that should not be part of the object model, much like the BOM and comments are not part of the object model. * When parsing a stylesheet, the first few bytes are scanned for a specific byte pattern to select an encoding. When the actual CSS parser comes to the @charset rule, it is parsed with normal @-rule syntax rules, which is laxer than the scanner. Thus the object model can be claiming an encoding that was not actually picked up by the @charset scanner. * CSSCharsetRule can be modified but that does not change the encoding of the stylesheet. * CSSCharsetRule complicates other parts of CSSOM e.g. insertRule, removeRule, CSSNamespaceRule. I've marked it as being considered for removal in the spec: https://dvcs.w3.org/hg/csswg/rev/86a5f6f5df18 115499 4 philipj 2014-11-26 08:49:02 +0000 Thanks, I'll try to get it removed from Blink and let you know how it goes! 116985 5 philipj 2015-01-10 00:45:08 +0000 It's been removed in Blink, but hasn't reached the stable channel yet: https://code.google.com/p/chromium/issues/detail?id=438147 119000 6 philipj 2015-03-28 02:45:32 +0000 The removal reached stable with M41 and Chrome 41 was released on March 3. I haven't heard anything and can't find any bug report, so it worked out well. Please remove from spec :) 119191 7 zcorpan 2015-04-02 09:37:32 +0000 OK, removed. https://github.com/w3c/csswg-drafts/commit/a7d1486917739758f84e3324d8082632f94509a8 Tab, please make css-syntax not create an at-rule for @charset and then reassign to me, so CSSOM doesn't need to check for it in insertRule. 119388 8 jackalmage 2015-04-08 22:03:54 +0000 (In reply to Simon Pieters from comment #7) > Tab, please make css-syntax not create an at-rule for @charset and then > reassign to me, so CSSOM doesn't need to check for it in insertRule. Done. It's now explicitly defined as not a valid rule, and the first one in a stylesheet is explicitly dropped during stylesheet parsing, so grammar-checking that requires some rules (like @import) to be first in the stylesheet won't get messed up. 119392 9 zcorpan 2015-04-09 12:22:19 +0000 https://github.com/w3c/csswg-drafts/commit/8398f6ff88eafc91b307919d6a9ce8fe52a0e750 119492 10 philipj 2015-04-14 11:49:40 +0000 Thanks all!