27383 2014-11-20 19:06:20 +0000 Incorrect link for "encode" reference since Bikeshed conversion 2014-12-06 12:17:05 +0000 1 1 1 Unclassified WHATWG URL unspecified PC Linux RESOLVED FIXED P2 normal Unsorted 1 simon.sapin rubys annevk mike rubys sideshowbarker+urlspec oldest_to_newest 115253 0 simon.sapin 2014-11-20 19:06:20 +0000 In the application/x-www-form-urlencoded serializer: > Replace outputPair's name and value with the result of running encode on them using encoding override, respectively. "encode" incorrectly links to https://encoding.spec.whatwg.org/#encoding instead of https://encoding.spec.whatwg.org/#encode like it did before the conversion to Bikeshed. The corresponding source in url.bs is just <a>encode</a>, so the issue is probably in the cross-reference data that Bikeshed uses. Compare a snapshot of current master: https://rawgit.com/whatwg/url/898cc941ed34996cd504bd345635d73b3de666a1/url.html#concept-urlencoded-serializer And a snapshot of a recent commit, before conversion to Bikeshed: https://rawgit.com/whatwg/url/f765c1ad6bf6e339f5ccca0476ea6ef1c1ff51cf/url.html#concept-urlencoded-serializer 115679 1 rubys 2014-11-29 00:54:33 +0000 Fixed https://github.com/whatwg/url/commit/322212d78755206181ae1de7e4ec626d0a06a46f 115685 2 annevk 2014-11-29 15:25:17 +0000 That first change is wrong. It should link to #encode, that's why it has title=encode. 115688 3 rubys 2014-11-29 15:53:02 +0000 title is not sufficient for bikeshed. Refixed: https://github.com/whatwg/url/commit/3d97d99a941ab5f3a2b78ba739078553cb3cd205 115689 4 annevk 2014-11-29 15:55:50 +0000 It used to be sufficient in Anolis. So we may want to audit the specification since there could be many similar regressions if they are indeed not the same. 115692 5 rubys 2014-11-29 16:22:06 +0000 Either I haven't found it, or the documentation from bikeshed isn't clear, but from I have gathered: *) definitions are classified based on type (this part is clear in the documentation) *) if type is not specified, bikeshed will essentially guess (how this guessing is done isn't precisely spelled out) *) for definitions of type 'dfn' (the default), bikeshed will match text even if there are differences in case, or word endings (for example -s, -ing, etc.). In this case, encode is a verb, and encoding is a noun. To fix this but, I've defined encode as a 'function', and left encoding as a 'dfn'. Hopefully this will help those who are looking for other cases where links need to be updated. 115981 6 rubys 2014-12-06 12:17:05 +0000 I believe it is correct now. Please reopen if not.