<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>26601</bug_id>
          
          <creation_ts>2014-08-18 22:09:55 +0000</creation_ts>
          <short_desc>Populate fullscreenElements later in requestFullscreen()</short_desc>
          <delta_ts>2014-08-26 11:57:51 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebAppsWG</product>
          <component>Fullscreen</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philip Jägenstedt">philipj</reporter>
          <assigned_to name="Anne">annevk</assigned_to>
          <cc>mike</cc>
    
    <cc>public-webapps</cc>
          
          <qa_contact>public-webapps-bugzilla</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>110267</commentid>
    <comment_count>0</comment_count>
    <who name="Philip Jägenstedt">philipj</who>
    <bug_when>2014-08-18 22:09:55 +0000</bug_when>
    <thetext>http://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

fullscreenElements is populated synchronously, but before the animation frame task is run, the elements of fullscreenElements may have been moved in ways that still passes the ready checks, but leaves the resulting fullscreen element stacks inconsistent, for example if the pending element is moved between two iframes immediately after requestFullscreen() returns.

The fix should be to populate the list of newly fullscreen elements in the animation frame task, immediately before pushing to stacks and firing events.

Note that in such a rewrite, the ready check could be performed for only the pending element, since it is now recursive.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110584</commentid>
    <comment_count>1</comment_count>
    <who name="Anne">annevk</who>
    <bug_when>2014-08-26 09:11:55 +0000</bug_when>
    <thetext>https://github.com/whatwg/fullscreen/commit/13e267c9bf275b645d4e7652e3acbc16f3dc5efb</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>110592</commentid>
    <comment_count>2</comment_count>
    <who name="Philip Jägenstedt">philipj</who>
    <bug_when>2014-08-26 11:57:51 +0000</bug_when>
    <thetext>LGTM and follow-up:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=26671</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>