26179 2014-06-23 15:50:43 +0000 toString should be non enumerable 2016-04-21 09:53:38 +0000 1 1 1 Unclassified WebAppsWG WebIDL unspecified All All RESOLVED WONTFIX P2 normal --- 1 erik.arvidsson cam annevk bzbarsky jl mike philipj public-script-coord sof public-webapps-bugzilla oldest_to_newest 108222 0 erik.arvidsson 2014-06-23 15:50:43 +0000 The toString function should be non enumerable to match ES builtins. http://heycam.github.io/webidl/#es-stringifier 108223 1 bzbarsky 2014-06-23 16:34:36 +0000 Does that match current UA behavior for HTMLAnchorElement and Location? 108225 2 erik.arvidsson 2014-06-23 16:54:06 +0000 Chrome, Firefox & IE: window.location.propertyIsEnumerable('toString') false Chrome, Firefox & IE: document.createElement('a').propertyIsEnumerable('toString') false However: Chrome: HTMLAnchorElement.prototype.propertyIsEnumerable('toString') false Firefox & IE: HTMLAnchorElement.prototype.propertyIsEnumerable('toString') true This looks like a bug in IE's and Firefox's DOM bindings 108226 3 bzbarsky 2014-06-23 17:09:08 +0000 > document.createElement('a').propertyIsEnumerable('toString') The property is not a property on the element itself. It's a property on the prototype. Nonexistent properties report "false" from propertyIsEnumerable (see ES6 19.1.3.4 step 7). You'd get false for document.createElement('a').propertyIsEnumerable('oblongify') too. So it sounds like in Firefox and IE this is an enumerable property on the prototype, as per current spec. It's not clear what you think the bug in their binding implementations is, exactly unless it's "not matching the behavior I want for this property"... Now maybe we can change browser behavior without breaking sites, given that the property is not enumerable in Chrome. I checked, and it's not enumerable in Safari either. 108227 4 bzbarsky 2014-06-23 17:09:43 +0000 HTMLAnchorElement.prototype.toString is enumerable in Presto-based Opera, fwiw. 108243 5 erik.arvidsson 2014-06-23 20:35:17 +0000 (In reply to Boris Zbarsky from comment #3) > > document.createElement('a').propertyIsEnumerable('toString') > > The property is not a property on the element itself. It's a property on > the prototype. Nonexistent properties report "false" from > propertyIsEnumerable (see ES6 19.1.3.4 step 7). You'd get false for > document.createElement('a').propertyIsEnumerable('oblongify') too. I forgot that propertyIsEnumerable is only for own properties. Then the IE and FF results are consistent. 125943 6 sof 2016-04-20 13:56:57 +0000 Blink is phasing out the use of non-enumerable toString() and implementing 'stringifier' as spec'ed; see https://bugs.chromium.org/p/chromium/issues/detail?id=306606 and an initial set of these changes ( https://codereview.chromium.org/1905553002/ ) 125944 7 annevk 2016-04-20 14:05:32 +0000 Sigbjørn, does that mean we can close this? 125945 8 sof 2016-04-20 14:47:53 +0000 How you handle long-opened bugs with no activity I will leave up to you :) Moving Blink to be stringifier-compatible seems preferable by now; we'll try. 125985 9 philipj 2016-04-21 08:50:30 +0000 I think this should be closed, these changes will bring Blink in line with Edge and Firefox, so there's not much reason to think it would change again once interoperable. 125987 10 annevk 2016-04-21 09:53:38 +0000 WONTFIXING since all implementations will seemingly align here with what was already required.