26133 2014-06-18 09:48:29 +0000 readyState cannot be HAVE_NOTHING in "If the media data is corrupted" 2014-10-08 13:48:31 +0000 1 1 1 Unclassified WHATWG HTML unspecified Other other RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/#fatal-decode-error P3 normal Unsorted 1 contributor ian ian mike philipj contributor oldest_to_newest 107994 0 contributor 2014-06-18 09:48:29 +0000 Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html Multipage: http://www.whatwg.org/C#fatal-decode-error Complete: http://www.whatwg.org/c#fatal-decode-error Referrer: http://www.whatwg.org/specs/web-apps/current-work/multipage/ Comment: readyState cannot be HAVE_NOTHING in "If the media data is corrupted" Posted from: 83.218.67.123 User agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.18 Safari/537.36 OPR/23.0.1528.0 (Edition Developer) 107997 1 philipj 2014-06-18 11:04:24 +0000 "Fatal errors in decoding the media data that occur after the user agent has established whether the current media resource is usable" means that readyState has already reached HAVE_METADATA, since that's where it says "This indicates that the resource is usable." That makes the HAVE_NOTHING case unreachable, and all that will remain is "Set the element's networkState attribute to the NETWORK_IDLE value." This is similar to a bug for the network case in 2011: https://www.w3.org/Bugs/Public/show_bug.cgi?id=12598 107999 2 philipj 2014-06-18 11:21:06 +0000 One caveat here is that the error event is fired synchronously, so the event handler could actually call load() or otherwise cause readyState to revert to HAVE_NOTHING, but when these steps were written the event was async so that's not the reason things are the way they are. Please also consider setting readyState before firing the event for both the network and decode error case, since otherwise networkState may not accurate reflect whatever the error event handler does. 110731 3 ian 2014-08-28 20:50:13 +0000 (In reply to Philip Jägenstedt from comment #1) > > That makes the HAVE_NOTHING case unreachable, and all that will remain is > "Set the element's networkState attribute to the NETWORK_IDLE value." Fixed. (In reply to Philip Jägenstedt from comment #2) > > Please also consider setting readyState before firing the event for both the > network and decode error case, since otherwise networkState may not accurate > reflect whatever the error event handler does. I assume you mean networkState, not readyState. Fixed. Let me know if this breaks something. 110733 4 contributor 2014-08-28 20:53:21 +0000 Checked in as WHATWG revision r8726. Check-in comment: <video>: Remove some redundant prose, and change when networkState is updated with respect to 'error' events http://html5.org/tools/web-apps-tracker?from=8725&to=8726 112823 5 philipj 2014-10-08 13:48:31 +0000 I've reviewed the changes and they LGTM. Blink already does what the spec now says in these steps, modulo event timing. (It queues tasks to fire rather than firing as part of these algorithms.)