261 2003-06-30 09:22:02 +0000 hc_nodeinsertbefore relies on parser specifics (whitespace handling). 2003-09-23 05:04:33 +0000 1 1 1 Unclassified DOM TS DOM Level 1 unspecified PC Linux RESOLVED FIXED P2 normal --- 1 faure plh oldest_to_newest 620 0 faure 2003-06-30 09:22:02 +0000 The DOM1 hc_nodeinsertbefore test relies on a specificity of the Mozilla parser: when a <p> tag has a newline before the first child tag, Mozilla creates a text node to hold that (whitespace-only) text. Internet Explorer doesn't do that, and Konqueror neither. hc_nodeinsertbefore relies on the <sup> tag being at position 7 (the 8th child) among the children of the <p> tag. In IE and Konq, it is at position 6, since there's no leading text node. Can the test be changed to use something safer than getting a child by its index, for instance getElementsByTagName or namedItem? 621 1 40 faure 2003-06-30 09:26:13 +0000 Created attachment 40 standalone testcase 773 2 carnold 2003-09-23 01:04:33 +0000 The test was an transliteration of a NIST XML test. So it is not only Mozilla, but any XML parser, that would pass the test as written. That said, asserting the preservation of a leading whitespace in a p element was not the objective of the test. The following patch changes the test so it obtains the refChild child parameter using getElementsByTagname and is not affected by the elimination of the leading whitespace node. Index: hc_nodeinsertbefore.xml =================================================================== RCS file: /sources/public/2001/DOM-Test-Suite/tests/level1/core/hc_nodeinsertbefore.xml,v retrieving revision 1.4 diff -u -r1.4 hc_nodeinsertbefore.xml --- hc_nodeinsertbefore.xml 28 Jun 2003 19:11:05 -0000 1.4 +++ hc_nodeinsertbefore.xml 23 Sep 2003 04:42:16 -0000 @@ -19,8 +19,8 @@ The "insertBefore(newChild,refChild)" method inserts the node "newChild" before the node "refChild". - Insert a newly created Element node before the eigth - child of the second employee and check the "newChild" + Insert a newly created Element node before the second + sup element in the document and check the "newChild" and "refChild" after insertion for correct placement. </description> @@ -28,6 +28,7 @@ <subject resource="http://www.w3.org/TR/1998/REC-DOM-Level-1-19981001/level-one-core#ID-952280727"/> <subject resource="http://www.w3.org/Bugs/Public/show_bug.cgi?id=246"/> <subject resource="http://www.w3.org/Bugs/Public/show_bug.cgi?id=247"/> +<subject resource="http://www.w3.org/Bugs/Public/show_bug.cgi?id=261"/> </metadata> <var name="doc" type="Document"/> <var name="elementList" type="NodeList"/> @@ -50,10 +51,10 @@ </var> <var name="nodeType" type="int"/> <load var="doc" href="hc_staff" willBeModified="true"/> -<getElementsByTagName interface="Document" obj="doc" tagname='"p"' var="elementList"/> -<item interface="NodeList" obj="elementList" index="1" var="employeeNode"/> -<childNodes obj="employeeNode" var="childList"/> -<item interface="NodeList" obj="childList" index="7" var="refChild"/> +<getElementsByTagName interface="Document" obj="doc" tagname='"sup"' var="elementList"/> +<item interface="NodeList" obj="elementList" index="2" var="refChild"/> +<parentNode interface="Node" var="employeeNode" obj="refChild"/> +<childNodes var="childList" obj="employeeNode"/> <createElement obj="doc" tagName='"br"' var="newChild"/> <insertBefore var="insertedNode" obj="employeeNode" newChild="newChild" refChild="refChild"/> <for-each collection="childList" member="child"> 40 2003-06-30 09:26:13 +0000 2003-06-30 09:26:13 +0000 standalone testcase parsing.html text/html 765 faure PGh0bWw+Cjxib2R5PgoKIDxwPgogIDxlbT5FTVAwMDAyPC9lbT4KICA8c3Ryb25nPk1hcnRoYSBS YXlub2xkczwvc3Ryb25nPgogIDxjb2RlPlNlY3JldGFyeTwvY29kZT4KICA8c3VwPjM1LDAwMDwv c3VwPgogIDx2YXI+RmVtYWxlPC92YXI+CiAgPGFjcm9ueW0gdGl0bGU9IlllcyIgY2xhc3M9Illl cyI+JmJldGE7IERhbGxhcywgJmdhbW1hOwogOTg1NTQ8L2Fjcm9ueW0+CiA8L3A+CgogICAgICA8 c2NyaXB0PgogICAgICB2YXIgZW1wbG95ZWVOb2RlID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRh Z05hbWUoInAiKS5pdGVtKDApOwogICAgICB2YXIgY2hpbGRMaXN0ID0gZW1wbG95ZWVOb2RlLmNo aWxkTm9kZXM7CiAgICAgIHZhciBhY3R1YWwgPSBuZXcgQXJyYXkoKTsKCiAgICAgIGZvcih2YXIg X2luZGV4ID0gMDsgX2luZGV4IDwgY2hpbGRMaXN0Lmxlbmd0aDsgX2luZGV4KyspIHsKICAgICAg ICAgIGNoaWxkID0gY2hpbGRMaXN0Lml0ZW0oX2luZGV4KTsKICAgICAgICAgIG5vZGVUeXBlID0g Y2hpbGQubm9kZVR5cGU7CiAgICAgICAgICBpZiggKDEgPT0gbm9kZVR5cGUpKSB7CiAgICAgICAg ICAgICAgY2hpbGROYW1lID0gY2hpbGQubm9kZU5hbWU7CiAgICAgICAgICAgICAgYWN0dWFsW2Fj dHVhbC5sZW5ndGhdID0gY2hpbGROYW1lOwogICAgICAgICAgfSBlbHNlIGFjdHVhbFthY3R1YWwu bGVuZ3RoXSA9ICIoVEVYVCkiOwogICAgICB9CiAgICAgIGFsZXJ0KGFjdHVhbCk7CiAgICAgIDwv c2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K