<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>25977</bug_id>
          
          <creation_ts>2014-06-04 09:33:44 +0000</creation_ts>
          <short_desc>DTMFSender should have an onerror event handler</short_desc>
          <delta_ts>2014-06-11 07:19:43 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebRTC Working Group</product>
          <component>WebRTC API</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kiran">kiran.guduru</reporter>
          <assigned_to name="Web RTC Working Group">public-webrtc</assigned_to>
          <cc>adam.bergkvist</cc>
    
    <cc>juberti</cc>
    
    <cc>public-webrtc</cc>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>107250</commentid>
    <comment_count>0</comment_count>
    <who name="Kiran">kiran.guduru</who>
    <bug_when>2014-06-04 09:33:44 +0000</bug_when>
    <thetext>Errors on a DTMFSender need to be reported through an error event, say DTMFError.

1. Invalid DTMF values
2. Values of duration and interToneGap with out of range values.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107280</commentid>
    <comment_count>1</comment_count>
    <who name="Justin Uberti">juberti</who>
    <bug_when>2014-06-04 18:28:52 +0000</bug_when>
    <thetext>Shouldn&apos;t those throw an exception? Those can be easily detected synchronously.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107332</commentid>
    <comment_count>2</comment_count>
    <who name="Kiran">kiran.guduru</who>
    <bug_when>2014-06-05 09:47:15 +0000</bug_when>
    <thetext>(In reply to Justin Uberti from comment #1)
&gt; Shouldn&apos;t those throw an exception? Those can be easily detected
&gt; synchronously.

I agree that duration and interToneGap ranges can be detected and thrown as exceptions.

But onerror seems still required for reporting error in case of inserting invalid DTMF values [1], Bug: 25837. 

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25837</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107388</commentid>
    <comment_count>3</comment_count>
    <who name="Justin Uberti">juberti</who>
    <bug_when>2014-06-05 17:46:05 +0000</bug_when>
    <thetext>It&apos;s not required - we could parse the string synchronously and return an error, which would be nicer than playing out some tones and then stopping with an error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107634</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2014-06-11 07:19:43 +0000</bug_when>
    <thetext>(In reply to Kiran from comment #0)
&gt; 1. Invalid DTMF values

Updated insertDTMF() algorithm to ignore unrecognized characters. Proposed fix [1] 

&gt; 2. Values of duration and interToneGap with out of range values.

This was fixed in [2].


Closing this bug as WONTFIX.

[1] https://github.com/fluffy/webrtc-w3c/commit/d58a8bcf7ac4998dea3f670ccd278ce1c0b6c89e
[2] https://www.w3.org/Bugs/Public/show_bug.cgi?id=25976</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>