<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>25976</bug_id>
          
          <creation_ts>2014-06-04 09:33:02 +0000</creation_ts>
          <short_desc>DTMFSender.insertDTMF steps should validate the values of duration and interToneGap.</short_desc>
          <delta_ts>2014-06-09 08:35:58 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebRTC Working Group</product>
          <component>WebRTC API</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kiran">kiran.guduru</reporter>
          <assigned_to name="Web RTC Working Group">public-webrtc</assigned_to>
          <cc>adam.bergkvist</cc>
    
    <cc>public-webrtc</cc>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>107249</commentid>
    <comment_count>0</comment_count>
    <who name="Kiran">kiran.guduru</who>
    <bug_when>2014-06-04 09:33:02 +0000</bug_when>
    <thetext>The steps of insertDTMF should validate values of duration and interToneGap before assigning.

Following step can be added to validate it.

3. If the values of duration or interToneGap are out of the specified range, return and abort these steps.

or

3. If the values of duration or interToneGap are out of the specified range, throw the corresponding error and abort these steps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107482</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2014-06-08 15:22:07 +0000</bug_when>
    <thetext>This has been talked about before and if I remember correctly we decided not to throw, but to clamp the input values to the valid ranges.

Something like:

x. If duration is less than 40 ms, let duration be 40 ms. Otherwise, if duration is greater than 6000 ms, let duration be 6000 ms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107509</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2014-06-09 08:35:58 +0000</bug_when>
    <thetext>Added default values to the idl and updated the algorithm.

Proposed fix: https://github.com/fluffy/webrtc-w3c/commit/02f5a3ac13c9c343747be75b8d8a2a874d5b8d8c

Closing bug.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>