<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>25892</bug_id>
          
          <creation_ts>2014-05-27 10:11:46 +0000</creation_ts>
          <short_desc>SignalingStateChange event should be fired only if there is a change in signaling state.</short_desc>
          <delta_ts>2014-06-09 08:47:07 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebRTC Working Group</product>
          <component>WebRTC API</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kiran">kiran.guduru</reporter>
          <assigned_to name="Web RTC Working Group">public-webrtc</assigned_to>
          <cc>adam.bergkvist</cc>
    
    <cc>public-webrtc</cc>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>106830</commentid>
    <comment_count>0</comment_count>
    <who name="Kiran">kiran.guduru</who>
    <bug_when>2014-05-27 10:11:46 +0000</bug_when>
    <thetext>SignalingStateChange event is being fired as a result of setLocalDescription / setRemoteDescription.
But there are cases where signaling state will not be changed as a result of setLocalDescription / setRemoteDescription, for example.

pc.createOffer()
pc.setLocalDescription()
onSignalingStateChange() -- Event fired as a result of signaling state change
// Again if createOffer is called for second time.
pc.createOffer()
pc.setLocalDescription()
// There is no change in the signaling state but still onSignalingStateChange() event is firing.

Spec should modify text in setLocalDescription step 7 from


Fire a simple event named signalingstatechange at connection.

to 

Fire a simple event named signalingstatechange at connection, if signaling state is changed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107241</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2014-06-04 08:32:10 +0000</bug_when>
    <thetext>I believe you are right.

Proposed fix: https://github.com/fluffy/webrtc-w3c/commit/406f1aa7248583e8823d3560e61c3060f75a8e69</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>