25869 2014-05-23 00:27:51 +0000 DOMClassList.toggle 'force' parameter is "wonky API design" 2014-08-14 14:57:56 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified PC Linux RESOLVED WONTFIX P2 normal --- 1 roc annevk crimsteam d erik.arvidsson glenn ian mike mjs www-dom public-webapps-bugzilla oldest_to_newest 106688 0 roc 2014-05-23 00:27:51 +0000 The "force" parameter makes the toggle() API not toggle. This seems wrong. DOMClassList.set(classname, bool) would be much better. #whatwg feedback, FWIW: http://krijnhoetmer.nl/irc-logs/whatwg/20140523#l-109 106693 1 annevk 2014-05-23 06:49:05 +0000 This is shipping in browsers. E.g. try <script> document.body.classList.toggle("test", false); document.body.classList.toggle("x", true); </script> in Live DOM Viewer or some such. Seems like a pain to change now. 106696 2 roc 2014-05-23 09:19:01 +0000 OK, but is it used yet? 106697 3 annevk 2014-05-23 09:21:08 +0000 I guess someone would need to add telemetry / use counters to browsers. I can't answer that question. 107017 4 d 2014-05-30 05:51:47 +0000 I strongly disagree with this bug. "Toggling something to true" is a very common phrase in English. Even if it were not, jQuery's usage of it as such for many years has made it a common developer expectation. In fact, I remember specific developer complaints that classList's toggle did *not* have this functionality, back in the day: a kind of "why didn't they just copy jQuery; they still Just Don't Get It" diatribe. 107026 5 glenn 2014-05-30 14:02:21 +0000 No, it's definitely a bad, unintuitive API. I would never expect x.toggle(true) to mean "set x to true". It should have been "x.set(true/false)". We shouldn't copy bad APIs from jQuery because we think people will scoff at us for doing things better. However, I don't know if it's worth the effort it would take to find out if we can change this, and then to change it, with it already implemented in multiple browsers. It's probably just another ugly API that we'll have to live with. We could add set(value) and leave toggle(value) in, but then we pay the cost of redundant APIs, which is probably worse. 107031 6 glenn 2014-05-30 14:38:47 +0000 (In reply to Domenic Denicola from comment #4) > I strongly disagree with this bug. "Toggling something to true" is a very > common phrase in English. To clarify, "toggle something to X" isn't what "toggle" actions mean; the word programmers use is "set" (or "assign", or occasionally "put" or "write", but never "toggle"). "Toggle" means a change based on the previous state. 107032 7 d 2014-05-30 14:42:44 +0000 I disagree that the word programmers use is "set." The word programmers use is often "toggle," especially in the case of classes, visibility, or animations. 107203 8 annevk 2014-06-03 13:49:14 +0000 This was not fixed. It might be WONTFIX, but that depends on research per comment 3.