25182 2014-03-27 20:55:15 +0000 Should element with 0 clientWidth and clientHeight be considered visible? 2014-05-16 22:28:36 +0000 1 1 1 Unclassified Browser Test/Tools WG WebDriver unspecified All All RESOLVED FIXED P2 normal --- 20860 1 botalov.andrey vlotoshnikov dburns mike vlotoshnikov public-browser-tools-testing oldest_to_newest 103047 0 botalov.andrey 2014-03-27 20:55:15 +0000 Let's say there is element: <span style="border-style:solid;border-width:5px;"></span> This element has 0 clientWidth and clientHeight but its offsetWidth and offsetHeight are positive numbers. The spec currently says: "The element must have a height and width greater than 0px" without saying type of width/height. I made a quick test and the following element is clickable in Google Chrome: <span style="border-style:solid;border-width:5px;" onclick="console.log(1000)"></span> I think it should be clarified which type of width/height is meant. 103802 1 vlotoshnikov 2014-04-14 05:50:19 +0000 I'll work on getting visibility experts' attention. 104229 2 dburns 2014-04-22 23:44:22 +0000 landed in https://dvcs.w3.org/hg/webdriver/rev/28b6056637b2 105828 3 1476 vlotoshnikov 2014-05-13 11:08:24 +0000 Created attachment 1476 A few cleanups in section 10.1 105829 4 vlotoshnikov 2014-05-13 11:10:25 +0000 The newly added "The element must have a DOMRect height and a DOMRect width greater than 0px, as returned by element.getBoundingClientRect() , unless the element has a descendent with a positive height and width." does not mention which elements MUST/SHOULD/MAY be (considered) displayed. Also it is a slower check (descendents are involved) and some trivial checks go first in this algorithm. It makes sense to move all the trivial checks up. Also I noticed that "displayed" is used in most of the section while "shown" or "visible" on only a few occasions. I removed "if Javascript is enabled", too ( https://www.w3.org/Bugs/Public/show_bug.cgi?id=25681 ) I just attached a patch I suggest committing. 105830 5 vlotoshnikov 2014-05-13 11:12:29 +0000 Not sure if the email notifications fired up or not... Reopening just in case. 106127 6 1477 vlotoshnikov 2014-05-16 00:54:17 +0000 Created attachment 1477 Suggested ammended wording for "height and width > 0px" A new patch attached; only changes strictly related to this bug. 106192 7 dburns 2014-05-16 19:24:52 +0000 Landed in https://dvcs.w3.org/hg/webdriver/rev/d3d3f482328e 106207 8 botalov.andrey 2014-05-16 21:21:48 +0000 There is an extra space between "element." and "getBoundingClientRect()" now. 106229 9 dburns 2014-05-16 22:28:36 +0000 fixed in https://dvcs.w3.org/hg/webdriver/rev/ed9347dfddf6 1476 2014-05-13 11:08:24 +0000 2014-05-16 00:54:17 +0000 A few cleanups in section 10.1 displayed.diff text/plain 3955 vlotoshnikov ZGlmZiAtciA0NTljNmIxOWZjNjggd2ViZHJpdmVyLXNwZWMuaHRtbAotLS0gYS93ZWJkcml2ZXIt c3BlYy5odG1sCU1vbiBNYXkgMTIgMTE6NTg6NTQgMjAxNCArMDEwMAorKysgYi93ZWJkcml2ZXIt c3BlYy5odG1sCVR1ZSBNYXkgMTMgMDM6NTk6MjQgMjAxNCAtMDcwMApAQCAtMTAxOSwyMiArMTAx OSwyNCBAQAogPHAgY2xhc3M9Im5vdGUiPkNvbmZvcm1hbmNlIHRlc3RzIGZvciB0aGlzIHNlY3Rp b24gY2FuIGJlIGZvdW5kIGluIHRoZSA8YSBocmVmPSJodHRwczovL2dpdGh1Yi5jb20vdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy90cmVlL21hc3Rlci93ZWJkcml2ZXIvIj53ZWJkcml2ZXIgbW9kdWxl PC9hPiB1bmRlciB0aGUgImVsZW1lbnRfc3RhdGUiIGZvbGRlci48L3A+CiAgIDxzZWN0aW9uPgog ICAgIDxoMiBpZD0nZGV0ZXJtaW5pbmctaWYtZGlzcGxheWVkJz5EZXRlcm1pbmluZyBpZiBhbiBl bGVtZW50IGlzIGRpc3BsYXllZDwvaDI+Ci0gICAgICA8cD5UaGUgZm9sbG93aW5nIHN0ZXBzIE1V U1QgYmUgdXNlZCB0byBkZXRlcm1pbmUgaWYgYW4gZWxlbWVudCBpcyBkaXNwbGF5ZWQgdG8gYSB1 c2VyLiBUaGlzIHNwZWNpZmljYXRpb24gcmVmZXJzIHRvIHRoaXMgYXMgdGhlIGVsZW1lbnQgYmVp bmcgInNob3duIi48L3A+CisgICAgICA8cD5UaGUgZm9sbG93aW5nIHN0ZXBzIE1VU1QgYmUgdXNl ZCB0byBkZXRlcm1pbmUgaWYgYW4gZWxlbWVudCBpcyBkaXNwbGF5ZWQgdG8gYSB1c2VyLjwvcD4K ICAgICAgIDx1bD4KLSAgICAgICAgPGxpPlRoZSBCT0RZIGVsZW1lbnQgTVVTVCBiZSBkaXNwbGF5 ZWQgaXJyZXNwZWN0aXZlIG9mIGFueSBDU1Mgc3R5bGU8L2xpPgotICAgICAgICA8bGk+VGhlIGVs ZW1lbnQgTVVTVCBoYXZlIGEgPGEgaHJlZj0naHR0cDovL2Rldi53My5vcmcvZnh0Zi9nZW9tZXRy eS9PdmVydmlldy5odG1sI2RvbS1kb21yZWN0LWRvbXJlY3QnPkRPTVJlY3Q8L2E+IGhlaWdodCBh bmQgYSA8YSBocmVmPSdodHRwOi8vZGV2LnczLm9yZy9meHRmL2dlb21ldHJ5L092ZXJ2aWV3Lmh0 bWwjZG9tLWRvbXJlY3QtZG9tcmVjdCc+RE9NUmVjdDwvYT4gd2lkdGggZ3JlYXRlciB0aGFuIDBw eCwgYXMgcmV0dXJuZWQgYnkgPGNvZGU+ZWxlbWVudC48YSBocmVmPSdodHRwOi8vZGV2LnczLm9y Zy9jc3N3Zy9jc3NvbS12aWV3LyNkb20tZWxlbWVudC1nZXRib3VuZGluZ2NsaWVudHJlY3QnPmdl dEJvdW5kaW5nQ2xpZW50UmVjdCgpPC9hPjwvY29kZT4gLCB1bmxlc3MgdGhlCi0gICAgICAgIGVs ZW1lbnQgaGFzIGEgZGVzY2VuZGVudCB3aXRoIGEgcG9zaXRpdmUgaGVpZ2h0IGFuZCB3aWR0aC48 L2xpPgorICAgICAgICA8bGk+VGhlIEJPRFkgZWxlbWVudCBNVVNUIGJlIGRpc3BsYXllZCBpcnJl c3BlY3RpdmUgb2YgYW55IENTUyBzdHlsZS48L2xpPgogICAgICAgICA8bGk+SWYgZWxlbWVudCBp cyBhIFtbIURPTTRdXSA8YSBocmVmPSJodHRwOi8vd3d3LnczLm9yZy9UUi8yMDEyL1dELWRvbS0y MDEyMDEwNS8jaW50ZXJmYWNlLXRleHQiPgotICAgICAgICAgIHRleHQgbm9kZTwvYT4gdGhlbiBp dCBNVVNUIGJlIHZpc2libGUuPC9saT4KKyAgICAgICAgICB0ZXh0IG5vZGU8L2E+IHRoZW4gaXQg TVVTVCBiZSBkaXNwbGF5ZWQuPC9saT4KICAgICAgICAgPGxpPlRoZSBlbGVtZW50IE1VU1QgTk9U IGJlIGRpc3BsYXllZCBpZiB0aGF0IGVsZW1lbnQsIG9yIGFueSBvZiBpdHMgYW5jZXN0b3JzLAog ICAgICAgICBoYXMgYSA8YSBocmVmPSdodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNS9lZGl0aW5n Lmh0bWwjdGhlLWhpZGRlbi1hdHRyaWJ1dGUnPmhpZGRlbiBhdHRyaWJ1dGU8L2E+IG9yIGhhcyA8 Y29kZT5kaXNwbGF5Om5vbmU8L2NvZGU+IGluIGl0cyBjb21wdXRlZCBDU1Mgc3R5bGUuPC9saT4K KyAgICAgICAgPGxpPkFueSBJTlBVVCBlbGVtZW50cyBvZiAidHlwZT1oaWRkZW4iIE1VU1QgTk9U IGJlIGRpc3BsYXllZC48L2xpPgorICAgICAgICA8bGk+QW55IE5PU0NSSVBUIGVsZW1lbnRzIE1V U1QgTk9UIGJlIGRpc3BsYXllZC48L2xpPgorICAgICAgICA8bGk+SWYgZWxlbWVudCBvciBhdCBs ZWFzdCBvbmUgb2YgaXRzIGRlc2NlbmRlbnRzIGhhdmUgYm90aCA8YSBocmVmPSdodHRwOi8vZGV2 LnczLm9yZy9meHRmL2dlb21ldHJ5L092ZXJ2aWV3Lmh0bWwjZG9tLWRvbXJlY3QtZG9tcmVjdCc+ RE9NUmVjdDwvYT4KKyAgICAgICAgaGVpZ2h0IGFuZCBhIDxhIGhyZWY9J2h0dHA6Ly9kZXYudzMu b3JnL2Z4dGYvZ2VvbWV0cnkvT3ZlcnZpZXcuaHRtbCNkb20tZG9tcmVjdC1kb21yZWN0Jz5ET01S ZWN0PC9hPiB3aWR0aCBncmVhdGVyIHRoYW4gMHB4LCBhcyByZXR1cm5lZCBieQorICAgICAgICA8 Y29kZT5lbGVtZW50LjxhIGhyZWY9J2h0dHA6Ly9kZXYudzMub3JnL2Nzc3dnL2Nzc29tLXZpZXcv I2RvbS1lbGVtZW50LWdldGJvdW5kaW5nY2xpZW50cmVjdCc+Z2V0Qm91bmRpbmdDbGllbnRSZWN0 KCk8L2E+PC9jb2RlPgorICAgICAgICB0aGVuIGl0IE1VU1QgYmUgZGlzcGxheWVkLgogICAgICAg ICA8bGk+VGhlIGVsZW1lbnQgTVVTVCBOT1QgYmUgZGlzcGxheWVkIGlmIHRoZXJlIGlzIGEgW1sh Y3NzMy0yZC10cmFuc2Zvcm1zXV0gb3IgW1shY3NzMy0zZC10cmFuc2Zvcm1zXV0KICAgICAgICAg cHJvcGVydHkgdGhhdCBnaXZlcyBhIG5lZ2F0aXZlIHggb3IgeSB0byB0aGUgY2FudmFzLiBUaGUg VXNlciBBZ2VudCBNVVNUIE5PVCBhbGxvdyBuZWdhdGl2ZSBzY3JvbGxpbmcuPC9saT4KLSAgICAg ICAgPGxpPk9QVElPTnMgYW5kIE9QVEdST1VQIGVsZW1lbnRzIGFyZSB0cmVhdGVkIGFzIHNwZWNp YWwgY2FzZXMsIHRoZXkgYXJlIGNvbnNpZGVyZWQgc2hvd24gaWYgYW5kIG9ubHkgaWYgdGhlIGVu Y2xvc2luZyBzZWxlY3QgZWxlbWVudCBpcyBkaXNwbGF5ZWQuPC9saT4KLSAgICAgICAgPGxpPk1B UCBlbGVtZW50cyBhcmUgc2hvd24gaWYgYW5kIG9ubHkgaWYgdGhlIGltYWdlIGl0IHVzZXMgaXMg ZGlzcGxheWVkLiBBcmVhcyB3aXRoaW4KLSAgICAgICAgYSBtYXAgYXJlIHNob3duIGlmIHRoZSBl bmNsb3NpbmcgTUFQIGlzIGRpc3BsYXllZC48L2xpPgotICAgICAgICA8bGk+QW55IElOUFVUIGVs ZW1lbnRzIG9mICJ0eXBlPWhpZGRlbiIgYXJlIG5vdCBkaXNwbGF5ZWQ8L2xpPgotICAgICAgICA8 bGk+QW55IE5PU0NSSVBUIGVsZW1lbnRzIE1VU1QgTk9UIGJlIGRpc3BsYXllZCBpZiBKYXZhc2Ny aXB0IGlzIGVuYWJsZWQuPC9saT4KKyAgICAgICAgPGxpPk9QVElPTnMgYW5kIE9QVEdST1VQIGVs ZW1lbnRzIE1VU1QgYmUgZGlzcGxheWVkIGlmIGFuZCBvbmx5IGlmIHRoZSBlbmNsb3Npbmcgc2Vs ZWN0IGVsZW1lbnQgaXMgZGlzcGxheWVkLjwvbGk+CisgICAgICAgIDxsaT5NQVAgZWxlbWVudHMg YXJlIGRpc3BsYXllZCBpZiBhbmQgb25seSBpZiB0aGUgaW1hZ2UgaXQgdXNlcyBpcyBkaXNwbGF5 ZWQuIEFyZWFzIHdpdGhpbgorICAgICAgICBhIG1hcCBhcmUgZGlzcGxheWVkIGlmIHRoZSBlbmNs b3NpbmcgTUFQIGlzIGRpc3BsYXllZC48L2xpPgogICAgICAgICA8bGk+VGhlIGVsZW1lbnQgTVVT VCBOT1QgYmUgZGlzcGxheWVkIGlmIGFueSBhbmNlc3RvciBvZiB0aGUgZWxlbWVudCAgaGFzIGEg Zml4ZWQgc2l6ZSwgYW5kIGhhcyB0aGUgQ1NTIHN0eWxlIHdpdGggb25lIG9mIHRoZSBmb2xsb3dp bmcgPGNvZGU+b3ZlcmZsb3c6aGlkZGVuPC9jb2RlPiwgPGNvZGU+b3ZlcmZsb3cteDpoaWRkZW48 L2NvZGU+IG9yIDxjb2RlPm92ZXJmbG93LXk6aGlkZGVuPC9jb2RlPiwgYW5kIHRoZSBlbGVtZW50 J3MgbG9jYXRpb24gYXMgZGV0ZXJtaW5lZCBieSA8Y29kZT48YSBocmVmPSJodHRwOi8vd3d3Lncz Lm9yZy9UUi9jc3NvbS12aWV3LyNkb20tcmFuZ2UtZ2V0Y2xpZW50cmVjdHMiPmdldENsaWVudFJl Y3RzPC9hPjwvY29kZT4gaXMgbm90IHdpdGhpbiB0aGUgZml4ZWQgc2l6ZSBvZiB0aGUgcGFyZW50 LjwvbGk+CiAgICAgICA8L3VsPgogCg== 1477 2014-05-16 00:54:17 +0000 2014-05-16 00:54:17 +0000 Suggested ammended wording for "height and width > 0px" descendents.diff text/plain 1671 vlotoshnikov ZGlmZiAtciBjYWU2YTlkYjE1ZDUgMTBfZWxlbWVudF9zdGF0ZS5odG1sCi0tLSBhLzEwX2VsZW1l bnRfc3RhdGUuaHRtbAlUaHUgTWF5IDE1IDIxOjU1OjE0IDIwMTQgKzAxMDAKKysrIGIvMTBfZWxl bWVudF9zdGF0ZS5odG1sCVRodSBNYXkgMTUgMTc6NTE6MTAgMjAxNCAtMDcwMApAQCAtNiw4ICs2 LDEyIEBACiAgICAgICA8cD5UaGUgZm9sbG93aW5nIHN0ZXBzIE1VU1QgYmUgdXNlZCB0byBkZXRl cm1pbmUgaWYgYW4gZWxlbWVudCBpcyBkaXNwbGF5ZWQgdG8gYSB1c2VyLiBUaGlzIHNwZWNpZmlj YXRpb24gcmVmZXJzIHRvIHRoaXMgYXMgdGhlIGVsZW1lbnQgYmVpbmcgInNob3duIi48L3A+CiAg ICAgICA8dWw+CiAgICAgICAgIDxsaT5UaGUgQk9EWSBlbGVtZW50IE1VU1QgYmUgZGlzcGxheWVk IGlycmVzcGVjdGl2ZSBvZiBhbnkgQ1NTIHN0eWxlPC9saT4KLSAgICAgICAgPGxpPlRoZSBlbGVt ZW50IE1VU1QgaGF2ZSBhIDxhIGhyZWY9J2h0dHA6Ly9kZXYudzMub3JnL2Z4dGYvZ2VvbWV0cnkv T3ZlcnZpZXcuaHRtbCNkb20tZG9tcmVjdC1kb21yZWN0Jz5ET01SZWN0PC9hPiBoZWlnaHQgYW5k IGEgPGEgaHJlZj0naHR0cDovL2Rldi53My5vcmcvZnh0Zi9nZW9tZXRyeS9PdmVydmlldy5odG1s I2RvbS1kb21yZWN0LWRvbXJlY3QnPkRPTVJlY3Q8L2E+IHdpZHRoIGdyZWF0ZXIgdGhhbiAwcHgs IGFzIHJldHVybmVkIGJ5IDxjb2RlPmVsZW1lbnQuPGEgaHJlZj0naHR0cDovL2Rldi53My5vcmcv Y3Nzd2cvY3Nzb20tdmlldy8jZG9tLWVsZW1lbnQtZ2V0Ym91bmRpbmdjbGllbnRyZWN0Jz5nZXRC b3VuZGluZ0NsaWVudFJlY3QoKTwvYT48L2NvZGU+ICwgdW5sZXNzIHRoZQotICAgICAgICBlbGVt ZW50IGhhcyBhIGRlc2NlbmRlbnQgd2l0aCBhIHBvc2l0aXZlIGhlaWdodCBhbmQgd2lkdGguPC9s aT4KKyAgICAgICAgPGxpPklmIGVsZW1lbnQgb3IgYXQgbGVhc3Qgb25lIG9mIGl0cyBkZXNjZW5k ZW50cyBoYXZlIGJvdGgKKyAgICAgICAgPGEgaHJlZj0naHR0cDovL2Rldi53My5vcmcvZnh0Zi9n ZW9tZXRyeS9PdmVydmlldy5odG1sI2RvbS1kb21yZWN0LWRvbXJlY3QnPkRPTVJlY3Q8L2E+Cisg ICAgICAgIGhlaWdodCBhbmQgYSA8YSBocmVmPSdodHRwOi8vZGV2LnczLm9yZy9meHRmL2dlb21l dHJ5L092ZXJ2aWV3Lmh0bWwjZG9tLWRvbXJlY3QtZG9tcmVjdCc+RE9NUmVjdDwvYT4KKyAgICAg ICAgd2lkdGggZ3JlYXRlciB0aGFuIDBweCwgYXMgcmV0dXJuZWQgYnkgPGNvZGU+ZWxlbWVudC4K KyAgICAgICAgPGEgaHJlZj0naHR0cDovL2Rldi53My5vcmcvY3Nzd2cvY3Nzb20tdmlldy8jZG9t LWVsZW1lbnQtZ2V0Ym91bmRpbmdjbGllbnRyZWN0Jz5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTwv YT4KKyAgICAgICAgPC9jb2RlPnRoZW4gaXQgTVVTVCBiZSBkaXNwbGF5ZWQuPC9saT4KICAgICAg ICAgPGxpPklmIGVsZW1lbnQgaXMgYSBbWyFET000XV0gPGEgaHJlZj0iaHR0cDovL3d3dy53My5v cmcvVFIvMjAxMi9XRC1kb20tMjAxMjAxMDUvI2ludGVyZmFjZS10ZXh0Ij4KICAgICAgICAgICB0 ZXh0IG5vZGU8L2E+IHRoZW4gaXQgTVVTVCBiZSB2aXNpYmxlLjwvbGk+CiAgICAgICAgIDxsaT5U aGUgZWxlbWVudCBNVVNUIE5PVCBiZSBkaXNwbGF5ZWQgaWYgdGhhdCBlbGVtZW50LCBvciBhbnkg b2YgaXRzIGFuY2VzdG9ycywK