25114 2014-03-21 09:15:35 +0000 Why throw instead of no-op when open="" is absent? 2016-08-18 14:48:52 +0000 1 1 1 Unclassified WHATWG HTML unspecified Other other RESOLVED FIXED http://www.whatwg.org/specs/web-apps/current-work/#close-the-dialog P3 normal Unsorted 1 contributor ian annevk ian jonas mathias mike zcorpan contributor oldest_to_newest 102735 0 contributor 2014-03-21 09:15:35 +0000 Specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/commands.html Multipage: http://www.whatwg.org/C#close-the-dialog Complete: http://www.whatwg.org/c#close-the-dialog Referrer: http://www.whatwg.org/specs/web-apps/current-work/multipage/ Comment: Why throw instead of no-op when open="" is absent? Posted from: 90.230.218.37 by simonp@opera.com User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.112 Safari/537.36 OPR/20.0.1387.51 (Edition Next) 104453 1 ian 2014-04-25 17:44:59 +0000 Because if you call close() on a closed dialog, you almost certainly have a coding error, and throwing an exception lets you find out exactly where the error is with a stack trace. But I could go either way. Should we change this? 104525 2 zcorpan 2014-04-28 06:17:35 +0000 I figured that since the user can close dialogs with "escape", it could complicate things for the app developer and might result in cargo-cult always checking if the dialog is open before calling close() or using try/catch. As for coding errors, would it also be a coding error to close a modal dialog that is not the top-most modal dialog? 104594 3 ian 2014-04-28 22:12:26 +0000 (In reply to Simon Pieters from comment #2) > I figured that since the user can close dialogs with "escape", it could > complicate things for the app developer and might result in cargo-cult > always checking if the dialog is open before calling close() or using > try/catch. Yeah, I could see this going either way. > As for coding errors, would it also be a coding error to close a modal > dialog that is not the top-most modal dialog? Probably... Anyone else have an opinion? If nobody has anything else to add, I'll probably go with zcorpan's suggestion. 104666 4 zcorpan 2014-04-29 09:22:58 +0000 Trying to gather more feedback here: https://twitter.com/zcorpan/status/461067952100741120 104668 5 mathias 2014-04-29 09:30:57 +0000 I agree with zcorpan. Not having `close()` throw greatly simplifies scripts. 104678 6 annevk 2014-04-29 13:15:47 +0000 This should not throw. Tasks/microtasks want to race on closing the dialog without try/catch. Same with exitFullscreen() and a dozen other APIs. 104843 7 contributor 2014-04-30 18:44:16 +0000 Checked in as WHATWG revision r8591. Check-in comment: dialog.close() shouldn't throw http://html5.org/tools/web-apps-tracker?from=8590&to=8591 127156 8 zcorpan 2016-08-18 14:48:52 +0000 Chromium issue https://bugs.chromium.org/p/chromium/issues/detail?id=638943