248 2003-06-27 22:55:07 +0000 hc_nodecommentattribute and nodecommentattribute do not make stated assertion 2003-06-28 19:59:04 +0000 1 1 1 Unclassified DOM TS DOM Level 1 unspecified Other other RESOLVED FIXED P2 normal --- 1 carnold carnold oldest_to_newest 583 0 carnold 2003-06-27 22:55:07 +0000 The description of these tests state that they check that Node.attributes on a Comment node is null, but the do not make that assertion. In addition, the hc_ version will fail on implementations that do not preserve comments since it relies on comment nodes already in the source document. Since there are already tests that check that the expected number of comments are present and some HTML implementations report PI's and DTD's as comments, changing the hc_ test so that it creates the comment is beneficial. 594 1 28 carnold 2003-06-28 15:58:55 +0000 Created attachment 28 Patch 28 2003-06-28 15:58:55 +0000 2003-06-28 15:58:55 +0000 Patch bug248.patch text/plain 5642 carnold SW5kZXg6IGhjX25vZGVjb21tZW50bm9kZWF0dHJpYnV0ZXMueG1sDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg ZmlsZTogL3NvdXJjZXMvcHVibGljLzIwMDEvRE9NLVRlc3QtU3VpdGUvdGVzdHMvbGV2ZWwxL2Nv cmUvaGNfbm9kZWNvbW1lbnRub2RlYXR0cmlidXRlcy54bWwsdg0KcmV0cmlldmluZyByZXZpc2lv biAxLjENCmRpZmYgLXIxLjEgaGNfbm9kZWNvbW1lbnRub2RlYXR0cmlidXRlcy54bWwNCjNjMw0K PCBDb3B5cmlnaHQgKGMpIDIwMDEgV29ybGQgV2lkZSBXZWIgQ29uc29ydGl1bSwNCi0tLQ0KPiBD b3B5cmlnaHQgKGMpIDIwMDEtMjAwMyBXb3JsZCBXaWRlIFdlYiBDb25zb3J0aXVtLA0KMjlhMzAN Cj4gPHN1YmplY3QgcmVzb3VyY2U9Imh0dHA6Ly93d3cudzMub3JnL0J1Z3MvUHVibGljL3Nob3df YnVnLmNnaT9pZD0yNDgiLz4NCjMyZDMyDQo8IDx2YXIgbmFtZT0iZWxlbWVudExpc3QiIHR5cGU9 Ik5vZGVMaXN0Ii8+DQozM2EzNA0KPiA8dmFyIG5hbWU9Im5vZGVMaXN0IiB0eXBlPSJOb2RlTGlz dCIvPg0KMzRhMzYNCj4gPHZhciBuYW1lPSJub2RlVHlwZSIgdHlwZT0iaW50Ii8+DQozNiwzN2Mz OCw0Mg0KPCA8Y2hpbGROb2RlcyBvYmo9ImRvYyIgdmFyPSJlbGVtZW50TGlzdCIvPg0KPCA8aXRl bSBpbnRlcmZhY2U9Ik5vZGVMaXN0IiBvYmo9ImVsZW1lbnRMaXN0IiBpbmRleD0iMiIgdmFyPSJj b21tZW50Tm9kZSIvPg0KLS0tDQo+IDxjaGlsZE5vZGVzIG9iaj0iZG9jIiB2YXI9Im5vZGVMaXN0 Ii8+DQo+IDxmb3ItZWFjaCBjb2xsZWN0aW9uPSJub2RlTGlzdCIgbWVtYmVyPSJjb21tZW50Tm9k ZSI+DQo+IDxub2RlVHlwZSBvYmo9ImNvbW1lbnROb2RlIiB2YXI9Im5vZGVUeXBlIi8+DQo+IDxp Zj4NCj4gPGVxdWFscyBhY3R1YWw9Im5vZGVUeXBlIiBleHBlY3RlZD0iOCIgaWdub3JlQ2FzZT0i ZmFsc2UiLz4NCjM4YTQ0LDQ5DQo+IDxhc3NlcnROdWxsIGFjdHVhbD0iYXR0ckxpc3QiIGlkPSJl eGlzdGluZ0NvbW1lbnRBdHRyaWJ1dGVzTnVsbCIvPg0KPiA8L2lmPg0KPiA8L2Zvci1lYWNoPg0K PiA8Y3JlYXRlQ29tbWVudCB2YXI9ImNvbW1lbnROb2RlIiBvYmo9ImRvYyIgZGF0YT0nIlRoaXMg aXMgYSBjb21tZW50IicvPg0KPiA8YXR0cmlidXRlcyBvYmo9ImNvbW1lbnROb2RlIiB2YXI9ImF0 dHJMaXN0Ii8+DQo+IDxhc3NlcnROdWxsIGFjdHVhbD0iYXR0ckxpc3QiIGlkPSJjcmVhdGVkQ29t bWVudEF0dHJpYnV0ZXNOdWxsIi8+DQpJbmRleDogaGNfbm9kZWNvbW1lbnRub2RlbmFtZS54bWwN Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0NClJDUyBmaWxlOiAvc291cmNlcy9wdWJsaWMvMjAwMS9ET00tVGVzdC1TdWl0 ZS90ZXN0cy9sZXZlbDEvY29yZS9oY19ub2RlY29tbWVudG5vZGVuYW1lLnhtbCx2DQpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMQ0KZGlmZiAtcjEuMSBoY19ub2RlY29tbWVudG5vZGVuYW1lLnhtbA0K M2MzDQo8IENvcHlyaWdodCAoYykgMjAwMSBXb3JsZCBXaWRlIFdlYiBDb25zb3J0aXVtLA0KLS0t DQo+IENvcHlyaWdodCAoYykgMjAwMS0yMDAzIFdvcmxkIFdpZGUgV2ViIENvbnNvcnRpdW0sDQoy OWEzMA0KPiA8c3ViamVjdCByZXNvdXJjZT0iaHR0cDovL3d3dy53My5vcmcvQnVncy9QdWJsaWMv c2hvd19idWcuY2dpP2lkPTI0OCIvPg0KNDRjNDUNCjwgPGFzc2VydEVxdWFscyBhY3R1YWw9ImNv bW1lbnROb2RlTmFtZSIgZXhwZWN0ZWQ9JyIjY29tbWVudCInIGlkPSJub2RlQ29tbWVudE5vZGVO YW1lQXNzZXJ0MSIgaWdub3JlQ2FzZT0iZmFsc2UiLz4NCi0tLQ0KPiA8YXNzZXJ0RXF1YWxzIGFj dHVhbD0iY29tbWVudE5vZGVOYW1lIiBleHBlY3RlZD0nIiNjb21tZW50IicgaWQ9ImV4aXN0aW5n Tm9kZU5hbWUiIGlnbm9yZUNhc2U9ImZhbHNlIi8+DQo0NmE0OCw1MA0KPiA8Y3JlYXRlQ29tbWVu dCB2YXI9ImNvbW1lbnROb2RlIiBvYmo9ImRvYyIgIGRhdGE9JyJUaGlzIGlzIGEgY29tbWVudCIn Lz4gDQo+IDxub2RlTmFtZSBvYmo9ImNvbW1lbnROb2RlIiB2YXI9ImNvbW1lbnROb2RlTmFtZSIv Pg0KPiA8YXNzZXJ0RXF1YWxzIGFjdHVhbD0iY29tbWVudE5vZGVOYW1lIiBleHBlY3RlZD0nIiNj b21tZW50IicgaWQ9ImNyZWF0ZWROb2RlTmFtZSIgaWdub3JlQ2FzZT0iZmFsc2UiLz4NCkluZGV4 OiBoY19ub2RlY29tbWVudG5vZGV0eXBlLnhtbA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9zb3Vy Y2VzL3B1YmxpYy8yMDAxL0RPTS1UZXN0LVN1aXRlL3Rlc3RzL2xldmVsMS9jb3JlL2hjX25vZGVj b21tZW50bm9kZXR5cGUueG1sLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xDQpkaWZmIC1yMS4x IGhjX25vZGVjb21tZW50bm9kZXR5cGUueG1sDQozYzMNCjwgQ29weXJpZ2h0IChjKSAyMDAxIFdv cmxkIFdpZGUgV2ViIENvbnNvcnRpdW0sDQotLS0NCj4gQ29weXJpZ2h0IChjKSAyMDAxLTIwMDMg V29ybGQgV2lkZSBXZWIgQ29uc29ydGl1bSwNCjI5YTMwDQo+IDxzdWJqZWN0IHJlc291cmNlPSJo dHRwOi8vd3d3LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MjQ4Ii8+DQo0M2M0 NA0KPCA8YXNzZXJ0RXF1YWxzIGFjdHVhbD0ibm9kZVR5cGUiIGV4cGVjdGVkPSI4IiBpZD0ibm9k ZUNvbW1lbnROb2RlVHlwZUFzc2VydDEiIGlnbm9yZUNhc2U9ImZhbHNlIi8+DQotLS0NCj4gPGFz c2VydEVxdWFscyBhY3R1YWw9Im5vZGVUeXBlIiBleHBlY3RlZD0iOCIgaWQ9ImV4aXN0aW5nQ29t bWVudE5vZGVUeXBlIiBpZ25vcmVDYXNlPSJmYWxzZSIvPg0KNDVhNDcsNDkNCj4gPGNyZWF0ZUNv bW1lbnQgdmFyPSJjb21tZW50Tm9kZSIgb2JqPSJkb2MiIGRhdGE9JyJUaGlzIGlzIGEgY29tbWVu dCInLz4NCj4gPG5vZGVUeXBlIG9iaj0iY29tbWVudE5vZGUiIHZhcj0ibm9kZVR5cGUiLz4NCj4g PGFzc2VydEVxdWFscyBhY3R1YWw9Im5vZGVUeXBlIiBleHBlY3RlZD0iOCIgaWQ9ImNyZWF0ZWRD b21tZW50Tm9kZVR5cGUiIGlnbm9yZUNhc2U9ImZhbHNlIi8+DQpJbmRleDogaGNfbm9kZWNvbW1l bnRub2RldmFsdWUueG1sDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL3NvdXJjZXMvcHVibGljLzIw MDEvRE9NLVRlc3QtU3VpdGUvdGVzdHMvbGV2ZWwxL2NvcmUvaGNfbm9kZWNvbW1lbnRub2RldmFs dWUueG1sLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xDQpkaWZmIC1yMS4xIGhjX25vZGVjb21t ZW50bm9kZXZhbHVlLnhtbA0KM2MzDQo8IENvcHlyaWdodCAoYykgMjAwMSBXb3JsZCBXaWRlIFdl YiBDb25zb3J0aXVtLA0KLS0tDQo+IENvcHlyaWdodCAoYykgMjAwMS0yMDAzIFdvcmxkIFdpZGUg V2ViIENvbnNvcnRpdW0sDQoyOWEzMA0KPiA8c3ViamVjdCByZXNvdXJjZT0iaHR0cDovL3d3dy53 My5vcmcvQnVncy9QdWJsaWMvc2hvd19idWcuY2dpP2lkPTI0OCIvPg0KNDVhNDcsNDkNCj4gPGNy ZWF0ZUNvbW1lbnQgdmFyPSJjb21tZW50Tm9kZSIgb2JqPSJkb2MiIGRhdGE9JyIgVGhpcyBpcyBh IGNvbW1lbnQiJy8+DQo+IDxub2RlVmFsdWUgb2JqPSJjb21tZW50Tm9kZSIgdmFyPSJjb21tZW50 VmFsdWUiLz4NCj4gPGFzc2VydEVxdWFscyBhY3R1YWw9ImNvbW1lbnRWYWx1ZSIgZXhwZWN0ZWQ9 JyIgVGhpcyBpcyBhIGNvbW1lbnQiJyBpZD0iY3JlYXRlZENvbW1lbnROb2RlVmFsdWUiIGlnbm9y ZUNhc2U9ImZhbHNlIi8+DQpJbmRleDogbm9kZWNvbW1lbnRub2RlYXR0cmlidXRlcy54bWwNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NClJDUyBmaWxlOiAvc291cmNlcy9wdWJsaWMvMjAwMS9ET00tVGVzdC1TdWl0ZS90 ZXN0cy9sZXZlbDEvY29yZS9ub2RlY29tbWVudG5vZGVhdHRyaWJ1dGVzLnhtbCx2DQpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNA0KZGlmZiAtcjEuNCBub2RlY29tbWVudG5vZGVhdHRyaWJ1dGVzLnht bA0KM2MzDQo8IENvcHlyaWdodCAoYykgMjAwMSBXb3JsZCBXaWRlIFdlYiBDb25zb3J0aXVtLA0K LS0tDQo+IENvcHlyaWdodCAoYykgMjAwMS0yMDAzIFdvcmxkIFdpZGUgV2ViIENvbnNvcnRpdW0s DQoyMSwyNGMyMSwyNQ0KPCAgICAgDQo8ICAgICBSZXRyaWV2ZSB0aGUgQ29tbWVudCBOb2RlKHRo aXJkIGNoaWxkKSBvZiB0aGUgRE9NIA0KPCAgICAgZG9jdW1lbnQgYW5kIGludm9rZSB0aGUgImdl dEF0dHJpYnV0ZXMoKSIgbWV0aG9kIG9uIHRoZSANCjwgICAgIENvbW1lbnQgTm9kZS4gICBJdCBz aG91bGQgcmV0dXJuIG51bGwuIA0KLS0tDQo+IA0KPiAgICAgRmluZCBhbnkgY29tbWVudCB0aGF0 IGlzIGFuIGltbWVkaWF0ZSBjaGlsZCBvZiB0aGUgcm9vdA0KPiAgICAgYW5kIGFzc2VydCB0aGF0 IE5vZGUuYXR0cmlidXRlcyBpcyBudWxsLiAgVGhlbiBjcmVhdGUNCj4gICAgIGEgbmV3IGNvbW1l bnQgbm9kZSAoaW4gY2FzZSB0aGV5IGhhZCBiZWVuIG9taXR0ZWQpIGFuZA0KPiAgICAgbWFrZSB0 aGUgYXNzZXJ0aW9uLiAgICANCjI5YTMxDQo+IDxzdWJqZWN0IHJlc291cmNlPSJodHRwOi8vd3d3 LnczLm9yZy9CdWdzL1B1YmxpYy9zaG93X2J1Zy5jZ2k/aWQ9MjQ4Ii8+DQozMiwzM2MzNCwzNQ0K PCA8dmFyIG5hbWU9ImVsZW1lbnRMaXN0IiB0eXBlPSJOb2RlTGlzdCIvPg0KPCA8dmFyIG5hbWU9 ImNvbW1lbnROb2RlIiB0eXBlPSJOb2RlIi8+DQotLS0NCj4gPHZhciBuYW1lPSJjaGlsZExpc3Qi IHR5cGU9Ik5vZGVMaXN0Ii8+DQo+IDx2YXIgbmFtZT0iY2hpbGROb2RlIiB0eXBlPSJOb2RlIi8+ DQozNGEzNw0KPiA8dmFyIG5hbWU9Im5vZGVUeXBlIiB0eXBlPSJpbnQiLz4NCjM2LDM4YzM5LDQ5 DQo8IDxjaGlsZE5vZGVzIG9iaj0iZG9jIiB2YXI9ImVsZW1lbnRMaXN0Ii8+DQo8IDxpdGVtIGlu dGVyZmFjZT0iTm9kZUxpc3QiIG9iaj0iZWxlbWVudExpc3QiIGluZGV4PSIyIiB2YXI9ImNvbW1l bnROb2RlIi8+DQo8IDxhdHRyaWJ1dGVzIG9iaj0iY29tbWVudE5vZGUiIHZhcj0iYXR0ckxpc3Qi Lz4NCi0tLQ0KPiA8Y2hpbGROb2RlcyBvYmo9ImRvYyIgdmFyPSJjaGlsZExpc3QiLz4NCj4gPGZv ci1lYWNoIGNvbGxlY3Rpb249ImNoaWxkTGlzdCIgbWVtYmVyPSJjaGlsZE5vZGUiPg0KPiA8bm9k ZVR5cGUgdmFyPSJub2RlVHlwZSIgb2JqPSJjaGlsZE5vZGUiLz4NCj4gPGlmPjxlcXVhbHMgYWN0 dWFsPSJub2RlVHlwZSIgZXhwZWN0ZWQ9IjgiLz4NCj4gPGF0dHJpYnV0ZXMgb2JqPSJjaGlsZE5v ZGUiIHZhcj0iYXR0ckxpc3QiLz4NCj4gPGFzc2VydE51bGwgYWN0dWFsPSJhdHRyTGlzdCIgaWQ9 ImF0dHJpYnV0ZXNOdWxsIi8+DQo+IDwvaWY+DQo+IDwvZm9yLWVhY2g+DQo+IDxjcmVhdGVDb21t ZW50IHZhcj0iY2hpbGROb2RlIiBvYmo9ImRvYyIgZGF0YT0nIlRoaXMgaXMgYSBjb21tZW50Iicv Pg0KPiA8YXR0cmlidXRlcyBvYmo9ImNoaWxkTm9kZSIgdmFyPSJhdHRyTGlzdCIvPg0KPiA8YXNz ZXJ0TnVsbCBhY3R1YWw9ImF0dHJMaXN0IiBpZD0iY3JlYXRlZEF0dHJpYnV0ZXNOdWxsIi8+DQo=