<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>24610</bug_id>
          
          <creation_ts>2014-02-10 20:44:37 +0000</creation_ts>
          <short_desc>What happens when unlockOrientation() is called but no orientation is locked?</short_desc>
          <delta_ts>2014-02-17 10:44:51 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebAppsWG</product>
          <component>HISTORICAL - Screen Orientation</component>
          <version>unspecified</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WORKSFORME</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">chris</reporter>
          <assigned_to name="Mounir Lamouri">mounir</assigned_to>
          <cc>mike</cc>
    
    <cc>public-webapps</cc>
    
    <cc>w3c</cc>
          
          <qa_contact>public-webapps-bugzilla</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>100197</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">chris</who>
    <bug_when>2014-02-10 20:44:37 +0000</bug_when>
    <thetext>What happens when unlockOrientation() is called but no orientation is locked?
The specification does not clearly mention this case, I assume we should return early (silently).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100739</commentid>
    <comment_count>1</comment_count>
    <who name="Mounir Lamouri">mounir</who>
    <bug_when>2014-02-17 10:30:46 +0000</bug_when>
    <thetext>The specification says:
&quot;&quot;&quot;
The unlockOrientation() method, when invoked, must disable the current lock applied on the screen with lockOrientation.
&quot;&quot;&quot;

There is obviously nothing to do if the screen orientation was not locked using lockOrientation().

Please reopen if you think this is not correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100741</commentid>
    <comment_count>2</comment_count>
    <who name="Marcos Caceres">w3c</who>
    <bug_when>2014-02-17 10:44:51 +0000</bug_when>
    <thetext>I think just add: &quot;Otherwise, if the screen orientation is not already in the default orientation, do nothing and return.&quot; Or something like that. 

Also, it should really say that unlocking returns to the default orientation. We rely on the concept of default orientation in the manifest spec, particularly to allow orientation changes. 

(unrelated: can you put &quot;&lt;dfn&gt;default orientation&lt;/dnf&gt;&quot; into the spec so I can link to the definition from the manifest spec).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>