24380 2014-01-24 07:12:12 +0000 [WebVTT] Don't extend TextTrack with WebVTT-specific members 2014-01-31 07:35:20 +0000 1 1 1 Unclassified TextTracks CG WebVTT unspecified PC All RESOLVED FIXED v1 P2 normal --- 1 philipj philipj mike public-texttracks rick.eyre silviapfeiffer1 victor.carbune dave.null oldest_to_newest 98985 0 philipj 2014-01-24 07:12:12 +0000 TextTrackCue was untangled from VTTCue on the grounds that WebVTT may not be the only text track type for all eternity. On the same reasoning, we shouldn't put VTT-specific things on TextTrack: interface TextTrack : EventTarget { attribute VTTRegionList? regions; void addRegion(VTTRegion region); void removeRegion(VTTRegion region); }; Spawned from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23686#c5 (I thought I had already filed a bug, but I can't find it.) 99316 1 philipj 2014-01-28 17:24:10 +0000 Suggested fix: 1. Change VTTCue to have an "attribute VTTRegion? region" instead of the regionId. 2. Remove the track and id attributes from from VTTRegion, since a region is now coupled with a cue directly, not via an id string. 3. Change the parser to use the id only during parsing to connect cues with regions. 4. Remove all of the extensions to TextTrack and with it the VTTRegionList interface. In short, make the region an attribute of the cue only. If you want to find all regions (why?) then look at your cues and if you want to remove a region just stop using it. This seems simpler to spec and implement, and reduces the API surface. Sounds good, Silvia? 99375 2 silviapfeiffer1 2014-01-29 00:18:46 +0000 Maybe I have to see this completely, but will this not lead to duplicating a region for every cue in it? (als cc-ing Victor for his feedback, since he implemented regions in blink/webkit) 99383 3 philipj 2014-01-29 02:39:55 +0000 (In reply to Silvia Pfeiffer from comment #2) > Maybe I have to see this completely, but will this not lead to duplicating a > region for every cue in it? No, the parser would have an id->VTTRegion mapping while it is running, so it would find the same region each time. 99386 4 victor.carbune 2014-01-29 08:08:36 +0000 (In reply to Philip Jägenstedt from comment #1) > In short, make the region an attribute of the cue only. If you want to find > all regions (why?) then look at your cues and if you want to remove a region > just stop using it. I think the change makes sense; it probably implies a bit more work for developers who will want to change region parameter through script, but re-building an id/region mapping is fairly trivial, if needed. 99390 5 philipj 2014-01-29 09:35:00 +0000 Here's my proposal implemented: https://github.com/w3c/webvtt/pull/31 99413 6 rick.eyre 2014-01-29 14:43:05 +0000 This was one of the things we were considering bringing up when we implemented this in Firefox. I'm all for this change. 99505 7 silviapfeiffer1 2014-01-30 22:21:20 +0000 OK, understood. I like the simplification. I guess a list of regions is now simply an array? 99527 8 philipj 2014-01-31 07:33:38 +0000 (In reply to Silvia Pfeiffer from comment #7) > OK, understood. I like the simplification. I guess a list of regions is now > simply an array? It's no longer exposed in any API, so it's just a conceptual list of no specific kind. As I wrote in one of the commit messages, I think that in the end we should have a (conceptual) id->region map in the parser, so that the id isn't a property of the region but just something required by the syntax. 99528 9 philipj 2014-01-31 07:35:20 +0000 Resolving this as fixed since the TextTrack interface extensions are no more: https://github.com/w3c/webvtt/commit/970b3a2d425d26e63fe2cd94b030f8f80289af00