24213 2014-01-06 18:17:09 +0000 MediaKeyNeededEvent's "type" attribute conflicts with Event's "type" attribute 2014-01-07 17:19:41 +0000 1 1 1 Unclassified HTML WG Encrypted Media Extensions unspecified All All RESOLVED FIXED P3 normal --- 1 ddorwin adrianba mike ppergame public-html-media public-html-bugzilla oldest_to_newest 98034 0 ddorwin 2014-01-06 18:17:09 +0000 The current definition of MediaKeyNeededEvent [1] includes an attribute named "type", which provides the value to pass to createSession()'s "type" parameter [2]. The problem is that Event [3], which MediaKeyNeededEvent inherits from, also has a "type" attribute that means something very different. We need to rename the "type" attribute on MediaKeyNeededEvent and probably the createSession() parameter as well for consistency. Background: * "type" was originally selected as the parameter name because it is similar to the same parameter in canPlayType(). * The "type" attribute was later added in bug 19096. [1] https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-mediakeyneededevent [2] https://dvcs.w3.org/hg/html-media/raw-file/default/encrypted-media/encrypted-media.html#dom-createsession [3] https://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#event 98039 1 ppergame 2014-01-06 20:14:43 +0000 How about "mimeType"? isTypeSupported takes a "type" as well, if we are going for overall consistency. 98088 2 adrianba 2014-01-07 16:23:32 +0000 I propose we use contentType, since this matches the header. I think it is okay to rename the arguments too. 98094 3 adrianba 2014-01-07 17:19:41 +0000 Fixed: https://dvcs.w3.org/hg/html-media/rev/1cbd047358a4