23969 2013-12-03 13:48:36 +0000 Non-ASCII application/x-www-form-urlencoded 2014-01-14 16:12:10 +0000 1 1 1 Unclassified WHATWG URL unspecified PC Linux RESOLVED FIXED P2 normal Unsorted 1 simon.sapin annevk mike zcorpan sideshowbarker+urlspec oldest_to_newest 97039 0 simon.sapin 2013-12-03 13:48:36 +0000 http://url.spec.whatwg.org/#application/x-www-form-urlencoded [[ The application/x-www-form-urlencoded parser takes a string input using code points in the range U+0000 to U+007F ]] Similarly to bug 23958, this parser seems to be called with unrestricted (potentially non-ASCII) input: new URLSearchParams('a=☃') 97043 1 annevk 2013-12-03 14:17:01 +0000 So the idea is to make the parser accept a byte sequence and then overload it with a parser that accepts a string. And then if you pass a string it'll simply utf-8 encode the string and invoke the byte version with the result. 97044 2 simon.sapin 2013-12-03 14:28:36 +0000 I’m a bit worried that, when used with a character encoding not as resilient as UTF-8, percent-escaped sequences could change the meaning of neighboring non-ASCII code points (since the character decoder that is called next doesn’t know what bytes come from the character encoder or from percent-escaping.) I think I prefer the design where consecutive percent-escaped sequences are character-decoded together. (Ie. percent decoding maps text to text and takes an encoding.) 97045 3 annevk 2013-12-03 14:30:40 +0000 The version that accepts strings would only ever use utf-8 and then pass the bytes to the byte version. 97046 4 simon.sapin 2013-12-03 14:44:00 +0000 What about application/x-www-form-urlencoded’s encoding override? 97049 5 annevk 2013-12-03 14:54:45 +0000 I cannot really think of a scenario where that would apply and the input would not be bytes. Probably need to add warnings and such though. 98428 6 annevk 2014-01-14 16:07:29 +0000 *** Bug 24146 has been marked as a duplicate of this bug. *** 98430 7 annevk 2014-01-14 16:12:10 +0000 Implemented comment 2 plus comment 5. https://github.com/whatwg/url/commit/3cfaa1779bfb9a3ba2b907a5802ca0251ca9a7e6