23790 2013-11-11 08:06:54 +0000 Remove size argument from read() and introduce pullAmount attribute instead 2013-12-05 19:56:34 +0000 1 1 1 Unclassified WebAppsWG Streams API unspecified All All RESOLVED FIXED P2 normal --- 1 tyoshino tyoshino mike public-webapps public-webapps-bugzilla oldest_to_newest 96111 0 tyoshino 2013-11-11 08:06:54 +0000 Now readExact() and read() are separate. It looks we should do further refactoring to remove size (actually meant maxSize) argument from read() and introduce pullAmount attribute instead. NOTE: This name (pullAmount) is chosen rather than "bufferSize" since it can have misleading message that we can control implementation detail of the producer. We supposed that most people don't want to manually control pull amount but just want to use default value. So, the pulling amount parameter should be provided as an attribute. 96139 1 tyoshino 2013-11-11 19:20:06 +0000 Since we cannot install a hook which is invoked right after fulfill callback is run, a user cannot decrease pullAmount on completion of one read(). pullAmount = 1024 ... readPromise is fulfilled with 512 bytes Fulfill callback is run asynchronously Inside fulfill callback we run this pullAmount = 512 But at this point, underlying IO may be already instructed to fetch 1024 bytes of data. We should enable gradual decrease of pullAmount? 96140 2 tyoshino 2013-11-11 19:41:30 +0000 (In reply to Takeshi Yoshino from comment #1) > Since we cannot install a hook which is invoked right after fulfill callback > is run, a user cannot decrease pullAmount on completion of one read(). > > pullAmount = 1024 > ... > readPromise is fulfilled with 512 bytes > Fulfill callback is run asynchronously > Inside fulfill callback we run this > pullAmount = 512 > But at this point, underlying IO may be already instructed to fetch 1024 > bytes of data. > > We should enable gradual decrease of pullAmount? Until next read() call, the number of bytes used for fulfilling the last read() call should occupy the pullAmount. 96236 3 tyoshino 2013-11-13 17:13:51 +0000 (In reply to Takeshi Yoshino from comment #2) > Until next read() call, the number of bytes used for fulfilling the last > read() call should occupy the pullAmount. Done in preview ver. bytesBeingOutpu does it. https://dvcs.w3.org/hg/streams-api/raw-file/tip/preview.html 96277 4 tyoshino 2013-11-14 01:51:34 +0000 Should pullAmount reset bytesBeingOutput? 97215 5 tyoshino 2013-12-05 19:56:34 +0000 Preview ver merged into ED. Closing this bug. (In reply to Takeshi Yoshino from comment #4) > Should pullAmount reset bytesBeingOutput? This is put into a separate bug entry. https://www.w3.org/Bugs/Public/show_bug.cgi?id=24008