<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://www.w3.org/Bugs/Public/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4"
          urlbase="https://www.w3.org/Bugs/Public/"
          
          maintainer="sysbot+bugzilla@w3.org"
>

    <bug>
          <bug_id>23698</bug_id>
          
          <creation_ts>2013-11-01 08:59:25 +0000</creation_ts>
          <short_desc>Rename ParentNode to ContainerNode or some other unambiguous name</short_desc>
          <delta_ts>2013-11-04 11:18:02 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebAppsWG</product>
          <component>DOM</component>
          <version>unspecified</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Anne">annevk</assigned_to>
          <cc>bugs</cc>
    
    <cc>ggaren</cc>
    
    <cc>mike</cc>
    
    <cc>www-dom</cc>
          
          <qa_contact>public-webapps-bugzilla</qa_contact>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>95660</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-11-01 08:59:25 +0000</bug_when>
    <thetext>The name ParentNode is exceedingly confusing because we already have parentNode() on Node.  Talking about the parentNode() of ParentNode, for example, will be very confusing.

In WebKit/Blink, we use call it ContainerNode since it&apos;s a node that could contain other nodes.

I&apos;m open to other names but please disambiguate from other DOM class and method names.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95666</commentid>
    <comment_count>1</comment_count>
    <who name="Olli Pettay">bugs</who>
    <bug_when>2013-11-01 11:12:24 +0000</bug_when>
    <thetext>Well, we have ChildNode too. So either call them ParentNode and ChildNode, 
or change both names.


But, I think having Node.parentNode pointing to a ParentNode looks pretty
good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95668</commentid>
    <comment_count>2</comment_count>
    <who name="Anne">annevk</who>
    <bug_when>2013-11-01 11:41:27 +0000</bug_when>
    <thetext>I would not know how to rename ChildNode. And I agree with Olli that the current names make a certain amount of sense.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95710</commentid>
    <comment_count>3</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-11-01 20:46:43 +0000</bug_when>
    <thetext>Is the value produced by Node.parentNode always of type ParentNode?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95711</commentid>
    <comment_count>4</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-11-01 21:20:43 +0000</bug_when>
    <thetext>&gt; I would not know how to rename ChildNode.

Let&apos;s not let a past bad naming decision justify a future bad naming decision. Or, as my mom likes to say, two wrongs don&apos;t make a right.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95736</commentid>
    <comment_count>5</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2013-11-03 00:56:42 +0000</bug_when>
    <thetext>Can&apos;t simply rename ChildNode to LeafNode?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95738</commentid>
    <comment_count>6</comment_count>
    <who name="Olli Pettay">bugs</who>
    <bug_when>2013-11-03 17:49:12 +0000</bug_when>
    <thetext>ChildNode is not necessarily a leaf.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>95758</commentid>
    <comment_count>7</comment_count>
    <who name="Anne">annevk</who>
    <bug_when>2013-11-04 11:18:02 +0000</bug_when>
    <thetext>(In reply to Geoffrey Garen from comment #3)
&gt; Is the value produced by Node.parentNode always of type ParentNode?

As far as I know, yes.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>