23586 2013-10-21 18:35:03 +0000 Naming conflict for query 2013-11-01 17:32:21 +0000 1 1 1 Unclassified WHATWG URL unspecified All All RESOLVED FIXED P2 normal Unsorted 1 erik.arvidsson annevk bkardell d ian mathias mike Ms2ger sideshowbarker+urlspec oldest_to_newest 95029 0 erik.arvidsson 2013-10-21 18:35:03 +0000 Both http://dom.spec.whatwg.org/#parentnode and http://url.spec.whatwg.org/#api defines a property named query. 95082 1 annevk 2013-10-22 10:21:22 +0000 Wow, even with the same author we get clashes. Sad times. I'm not sure which one to rename. Should we go for searchObj and URLSearch? 95118 2 erik.arvidsson 2013-10-22 20:17:24 +0000 Maybe name the property urlQuery? Another option is to not have a URL query property on HTMLAnchorElement nor HTMLTextAreaElement. 95129 3 d 2013-10-22 21:45:12 +0000 I am starting to like queryParams or queryPairs. (Or searchParams/searchPairs.) 95131 4 bkardell 2013-10-22 21:50:16 +0000 (In reply to Domenic Denicola from comment #3) > I am starting to like queryParams or queryPairs. (Or > searchParams/searchPairs.) +1 queryParams ... intuitive, been used before in other languages/frameworks/documentation and still fairly short. 95137 5 erik.arvidsson 2013-10-22 22:02:35 +0000 I'm also fine with queryParams. Should we rename URLQuery to QueryParams as well? 95172 6 annevk 2013-10-23 10:43:41 +0000 Where has queryParams been used before? And yeah, if we go with that we should probably rename the interface. 95185 7 bkardell 2013-10-23 12:49:25 +0000 (In reply to Anne from comment #6) > Where has queryParams been used before? And yeah, if we go with that we > should probably rename the interface. Seems to be pretty common parlance among devs to me - i see it in code frequently in several languages. some google searches show examples supporting... https://www.google.com/search? q=%E2%80%9Dqueryparams%E2%80%9D https://www.google.com/search? q=%E2%80%9Dqueryparams%E2%80% 9D+querystring https://www.google.com/search? q=%E2%80%9Dqueryparams%E2%80%9D+url 95684 8 annevk 2013-11-01 15:33:09 +0000 I'm still a bit torn. If we cannot use the actual proper term I think I somewhat prefer consistency with the existing API and either use searchObj or searchParams. I'm happy to be overruled though, it's not a big deal. 95685 9 bkardell 2013-11-01 15:52:35 +0000 (In reply to Anne from comment #8) > I'm still a bit torn. If we cannot use the actual proper term I think I > somewhat prefer consistency with the existing API and either use searchObj > or searchParams. > > I'm happy to be overruled though, it's not a big deal. searchParams isn't so bad... where is that more consistent though? non-sequitur complaint on the platform in general: I hate that we have so many properties that begin with a potential verb and therefore seem like they might be a method. Seems kinda bad because it blocks a potentially useful method name and leaves us in situations picking a less than ideal name. Don't really see a great solution here for that, just mentioning that it bothers me :) 95686 10 annevk 2013-11-01 16:01:54 +0000 So my thinking is that either we have the short good name query and ignore search exists. Or we embrace that search exists and offer a classList-like companion. searchObj mostly stems from HTMLMediaElement src / srcObj (although they might name it srcObject). 95690 11 erik.arvidsson 2013-11-01 16:59:14 +0000 (In reply to Anne from comment #10) > So my thinking is that either we have the short good name query and ignore > search exists. Or we embrace that search exists and offer a classList-like > companion. searchObj mostly stems from HTMLMediaElement src / srcObj > (although they might name it srcObject). I'm fine with searchObject but not with searchObj. We should not name things "obj". obj is fine for local variable names etc but we should not promote obj, doc, el, evt etc to APIs. Other options include {search,query}{List,Map,Object,Params} 95693 12 annevk 2013-11-01 17:09:58 +0000 Are you aware of srcdoc? Anyway, I am cool with searchParams with as object URLSearchParams. 95697 13 annevk 2013-11-01 17:32:21 +0000 https://github.com/whatwg/url/commit/0ca57a12e90099e00a0f142b7170d93fb11ab309