23365 2013-09-26 12:54:15 +0000 modify focus steps to move focus to dialog by default 2014-01-16 15:10:57 +0000 1 1 1 Unclassified HTML WG HTML5 spec unspecified PC Windows NT RESOLVED FIXED a11y P2 normal --- 23366 1 faulkner.steve faulkner.steve falken lwatson mike public-html-admin public-html-wg-issue-tracking silviapfeiffer1 surkov.alexander public-html-bugzilla oldest_to_newest 93871 0 faulkner.steve 2013-09-26 12:54:15 +0000 "Let control be the first element in tree order whose nearest ancestor dialog element is subject and that has an autofocus attribute specified, if any." modify this so that focus moves by default(does not need author to do). this will make it much better for keyboard/screen reader/screen mag users. 93872 1 sideshowbarker+gitzilla 2013-09-26 12:57:33 +0000 Commit pushed to master at https://github.com/w3c/html https://github.com/w3c/html/commit/210ea0850ab98bc566f575f4a7913074ea88b6b2 make focus move to dialog see bug 23365 93874 2 faulkner.steve 2013-09-26 13:02:07 +0000 rationale: currently moving focus to a dialog relies upon the author setting autofocus on one of the focusable elements in the dialog. As we know authors don't often think about keyboard interaction and if autofocus is not set it will 9as it is currently with custom dialogs) be problematic for SR,keyboard users and screen mag users. 93876 3 faulkner.steve 2013-09-26 13:14:12 +0000 see chrome bug - http://code.google.com/p/chromium/issues/detail?id=264959 93880 4 falken 2013-09-26 13:50:48 +0000 ""Let control be the first focusable element in tree order whose nearest ancestor dialog element is subject or that has an autofocus attribute specified." Maybe it should be more explicit that autofocus has priority? 93894 5 surkov.alexander 2013-09-26 15:55:33 +0000 (In reply to Matt Falkenhagen from comment #4) > ""Let control be the first focusable element in tree order whose nearest > ancestor dialog element is subject or that has an autofocus attribute > specified." > > Maybe it should be more explicit that autofocus has priority? agree since the statement form is "x or y" then the statement is true whenever x is true, so it can be read as focus first focusable control, otherwise focus unfocusable element having autfocus attribute. Also, a note, if the change concerns to modal dialogs only then it's probably fine since modal dialogs must take focus always but it'd double check that. 93899 6 falken 2013-09-26 17:29:01 +0000 (In reply to alexander surkov from comment #5) > (In reply to Matt Falkenhagen from comment #4) > > ""Let control be the first focusable element in tree order whose nearest > > ancestor dialog element is subject or that has an autofocus attribute > > specified." > > > > Maybe it should be more explicit that autofocus has priority? > > agree since the statement form is "x or y" then the statement is true > whenever x is true, so it can be read as focus first focusable control, > otherwise focus unfocusable element having autfocus attribute. True though what I was worried more about is ambiguity over whether the first element in tree order or an element with autofocus gets focus. 94552 7 faulkner.steve 2013-10-10 13:44:34 +0000 reverted commit, leaving it up to the acc engineers to work it out with hixie 94553 8 surkov.alexander 2013-10-10 13:48:48 +0000 (In reply to steve faulkner from comment #7) > reverted commit, leaving it up to the acc engineers to work it out with hixie how it could be wontfix if the fix was landed (comment #1)? Honestly I'm getting confused with number of bugs related to dialog element we have. 94554 9 faulkner.steve 2013-10-10 14:03:12 +0000 (In reply to alexander surkov from comment #8) > (In reply to steve faulkner from comment #7) > > reverted commit, leaving it up to the acc engineers to work it out with hixie > > how it could be wontfix if the fix was landed (comment #1)? Honestly I'm > getting confused with number of bugs related to dialog element we have. i reverted the fix 94555 10 surkov.alexander 2013-10-10 14:21:38 +0000 so the reason of wontfix is as soon as twin WHATWG bug is fixed then the change automatically goes into W3C spec. Correct? 94556 11 faulkner.steve 2013-10-10 14:28:40 +0000 (In reply to alexander surkov from comment #10) > so the reason of wontfix is as soon as twin WHATWG bug is fixed then the > change automatically goes into W3C spec. Correct? when/if the whatwg commit comes along unless anybody objects it will be committed to the HTML spec. 94557 12 faulkner.steve 2013-10-10 14:37:46 +0000 (In reply to steve faulkner from comment #9) > (In reply to alexander surkov from comment #8) > > (In reply to steve faulkner from comment #7) > > > reverted commit, leaving it up to the acc engineers to work it out with hixie > > > > how it could be wontfix if the fix was landed (comment #1)? Honestly I'm > > getting confused with number of bugs related to dialog element we have. > > i reverted the fix > Honestly I'm > getting confused with number of bugs related to dialog element we have. that's why i closed this one. 97638 13 silviapfeiffer1 2013-12-16 05:30:56 +0000 FYI: adopted commits from WHATWG: https://github.com/w3c/html/commit/49968eba023dc0d9b74ded165f29e37cfbf0ac81 and https://github.com/w3c/html/commit/e45d2cbeb7f242aec1825958beb1e552753c7cf2 98597 14 sideshowbarker+gitzilla 2014-01-16 15:10:57 +0000 Commit pushed to CR at https://github.com/w3c/html https://github.com/w3c/html/commit/210ea0850ab98bc566f575f4a7913074ea88b6b2 make focus move to dialog