23363 2013-09-26 09:27:37 +0000 requestFullscreen and dialog.showModal interaction 2013-11-07 13:58:07 +0000 1 1 1 Unclassified WebAppsWG Fullscreen unspecified PC Linux RESOLVED FIXED P2 normal --- 1 falken annevk ian mike public-webapps public-webapps-bugzilla oldest_to_newest 93865 0 falken 2013-09-26 09:27:37 +0000 What should the top layer be in the following case? dialog1.showModal(); dialog2.showModal(); dialog1.requestFullscreen(); I think dialog2 should be on top. This currently looks under spec'd though. showModal and requestFullscreen each require adding to the top of the top layer. A related case is: dialog1.requestFullscreen(); dialog2.showModal(); dialog1.showModal(); Maybe requestFullscreen should skip adding to top layer if it's already in the top layer. 93873 1 annevk 2013-09-26 12:58:25 +0000 It seems more like you want a different behavior from the specification? How is this not defined? If we want a change, an email to the WHATWG list outlining it including a pointer to this bug would be good. 93877 2 falken 2013-09-26 13:19:35 +0000 I guess what's not defined is what "add an element to the top layer" means when it's already in the top layer. Is it moved to the top of the top layer, remain where it is, or do you have two copies in the top layer? For example, the HTML spec says: "When an element is added to the pending dialog stack, it must also be added to the top layer layer." And requestFullscreen says: "add context object on document's fullscreen element stack", which leads to: "To add an element on a document's fullscreen element stack, add it on top of document's browsing context's top layer[...]" In these cases, what do you do if it's already in the top layer? Maybe I'm just reading too much into the word "add"... is the behavior actually well-defined here? 93980 3 annevk 2013-09-27 19:51:22 +0000 I guess we should clarify the top layer stack is an ordered set, semantically. Meaning that if the element is already in, it would just move around within the set. However, as you say in comment 0 we could make it not do that too. Not sure what is better. 95607 4 falken 2013-10-31 13:46:25 +0000 The ordered set behavior sounds OK to me, and thanks for clarifying. In comment 0 I'd forgotten that requestFullscreen terminates if it's "not allowed to show a popup", which basically means the user has to click something in the active modal dialog for something to go fullscreen over it. I was worried something would inadvertently go on top of the active modal dialog, and the user wouldn't be able to exit. 95944 5 annevk 2013-11-07 13:58:07 +0000 Thanks Matt! https://github.com/whatwg/fullscreen/commit/5664c8789bd31c1847220fea86da49966dcaf72f