23189 2013-09-09 19:22:51 +0000 Better defaults for #observe options 2013-09-10 12:10:07 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified PC All RESOLVED FIXED P2 normal --- 1 robin annevk bugs jonas mike www-dom public-webapps-bugzilla oldest_to_newest 93164 0 robin 2013-09-09 19:22:51 +0000 http://dom.spec.whatwg.org/#interface-mutationobserver [[ If attributeOldValue is true and attributes is not true, throw a "SyntaxError". If attributeFilter is a non-empty array and attributes is not true, throw a "SyntaxError". If characterDataOldValue is true and characterData is not true, throw a "SyntaxError". ]] Why not consider that attributes is automatically set to true for the first two, and likewise characterData for the third? It's certainly what the developer meant, and it's less typing. 93166 1 jonas 2013-09-09 21:11:47 +0000 I do think we want { attributes: false, attributeOldValue: true } and { characterData: false, characterOldData: true } to both throw an exception. What we could do is to make the default value of attributes/characterData depend on the value of the *Old* properties though, rather than being statically set in the WebIDL. 93180 2 bugs 2013-09-09 23:27:29 +0000 Yeah, if attributes is not set and attributeOldValue or attributeFilter is set (true or false and any array), then attributes becomes implicitly true. Same with characterData 93192 3 annevk 2013-09-10 11:04:27 +0000 So a new model would look like: dictionary MutationObserverInit { boolean childList = false; boolean attributes; boolean characterData; boolean subtree = false; boolean attributeOldValue = false; boolean characterDataOldValue = false; sequence<DOMString> attributeFilter; }; * If options' attributeOldValue is true and options' attributes is omitted, set options' attributes to true. * If options' attributeFilter is present and options' attributes is omitted, set options' attributes to true. * If options' characterDataOldValue is true and options' characterData is omitted, set options' characterData to true. * If none of options' childList, attributes, and characterData is true, throw a TypeError. * If attributeOldValue is true and attributes is false, throw a TypeError. * If attributeFilter is a non-empty array and attributes is false, throw a TypeError. * If characterDataOldValue is true and characterData is false, throw a TypeError. (I also changed the exception to a JavaScript TypeError in our quest to more closely integrate with JavaScript.) 93196 4 robin 2013-09-10 12:05:05 +0000 That LGTM. 93197 5 annevk 2013-09-10 12:10:07 +0000 I made a few more tweaks relative to comment 3. Only check for attributeFilter being present, rather than non-empty. Not have default values at all for the *OldValue members and check for their presence rather than checking if they are true when setting attributes/characterData to true. https://github.com/whatwg/dom/commit/a770b11981f4c147f98753cf726e44b14d17affc