22834 2013-07-30 00:15:04 +0000 DOM_KEY_LOCATION_MOBILE and _JOYSTICK are no longer needed 2013-09-05 16:37:05 +0000 1 1 1 Unclassified WebAppsWG HISTORICAL - DOM3 Events unspecified PC All RESOLVED FIXED P2 normal --- 1 garykac garykac bugs masayuki mike www-dom public-webapps-bugzilla oldest_to_newest 91397 0 garykac 2013-07-30 00:15:04 +0000 "_MOBILE" is not a well-defined term so it is unclear when this should be set to true. E.g., is a 10" tablet "mobile"? Where is the cutoff between mobile and non-mobile? "_JOYSTICK" is also probably not needed in this spec since the GamePad API (http://www.w3.org/TR/gamepad/) is meant for these devices. 91439 1 masayuki 2013-07-31 00:04:56 +0000 I understand the "MOBILE" can be used for mobile phone _OS_ which doesn't provide key location information because layout of VKB isn't similar to physical keyboard and/or apps cannot distinguish whether a key event is caused by physical keyboard or VKB. 91457 2 garykac 2013-07-31 13:41:25 +0000 So *every* key press on such a device would have location set to MOBILE? If so, the meaning of the setting isn't really "mobile", but rather "unknown" or "unspecified". Non-mobile devices could, in theory, make use of this value as well. But looking at Android's keycodes: http://developer.android.com/reference/android/view/KeyEvent.html they have separate values for Shift left/right, Control left/right and Meta left/right. The location field should be set appropriately for these key events, which precludes the use of MOBILE. I don't believe that MOBILE is a useful location to have in the spec. 91495 3 masayuki 2013-08-01 06:07:27 +0000 Gecko implemented so. But I agree, we can guess the location from keycode on Android. However, if there are some platforms whose application cannot distinguish left or right of modifier key, "unknown" sounds good to me. Additionally, Android and Linux has a lot of keycode which are not caused by standard keyboard. I believe that "unknown" should be used for them too. How about to add DOM_KEY_LOCATION_UNKNOWN as 0xFFFFFFFF and remove MOBILE and JOYSTICK? 91500 4 bugs 2013-08-01 11:33:53 +0000 Sounds ok to me. 92685 5 garykac 2013-08-28 14:00:54 +0000 I don't think having a separate _UNKNOWN value provides any value over simply using _STANDARD. And adding a new ("mobile"-only) value means that sites that check for _STANDARD (vs. _NUMPAD) are more likely to break on mobile. 93058 6 garykac 2013-09-05 16:37:05 +0000 Fixed in latest ED