2272 2005-09-20 17:19:37 +0000 <number> should not require a digit 2006-11-14 01:27:35 +0000 1 1 1 Unclassified CSSValidator CSS 2.0 CSS Validator All All RESOLVED FIXED P1 minor --- 1 former-z^corpan ylafon akuehn cssvalidator eric info jesse www-validator-cvs oldest_to_newest 6370 0 former-z^corpan 2005-09-20 17:19:38 +0000 According to CSS2, <number> could be an <integer>[1]. So the following style sheet is valid CSS2: E { line-height:1; } Reproducable: Always Steps to reproduce: 1. http://jigsaw.w3.org/css-validator/validator?text=E+%7B+line-height%3A1%3B+%7D&usermedium=all Actual results: "Invalid number : line-height Parse Error - [empty string]" Expected results: "No error or warning found" [1] http://www.w3.org/TR/REC-CSS2/syndata.html#value-def-number 6406 1 ot 2005-09-22 09:56:44 +0000 *** Bug 2285 has been marked as a duplicate of this bug. *** 6407 2 ot 2005-09-22 09:57:53 +0000 moving priority up (this should be fixed ASAP), severity down (probably easy to fix). Yves, if you have time for this... thanks. 8173 3 former-z^corpan 2006-02-09 13:09:04 +0000 *** Bug 2307 has been marked as a duplicate of this bug. *** 8186 4 406 jesse 2006-02-11 00:32:37 +0000 Created attachment 406 Patch to allow 'line-height: 1;' CssNumber.get() returns either a Float or an Integer. CssLineHeight* were assuming it was always a Float. I changed it so that getValue() is called instead for instances of CssValueFloat (ie. CssNumber). getValue() always returns Float. Note: this only fixes line-height. It's not clear if this bug (or a similar bug) exists elsewhere, though I couldn't find another occurance. 8295 5 408 jesse 2006-02-16 18:48:20 +0000 Created attachment 408 Fixes line-height: <number> I simplified the code. Now it just changes a Float cast to a Number cast. 8299 6 ot 2006-02-17 00:33:27 +0000 (In reply to comment #5) Jesse, thanks for your patch. We're reviewing it now. 8747 7 ot 2006-03-16 06:03:29 +0000 Jesse, Your patch is now in the CVS codebase, and tested successfully. We'll update the production service soon with it and a bunch of other bugfixes. Thanks! 12791 8 cssvalidator 2006-11-02 18:23:01 +0000 Is the online validator updated with this patch already? Cause {line-height:0;} still returns "Invalid number : line-height Parse Error - [empty string]". 12923 9 ot 2006-11-14 01:27:35 +0000 (In reply to comment #8) > Is the online validator updated with this patch already? Not yet. 406 2006-02-11 00:32:33 +0000 2006-02-16 18:48:20 +0000 Patch to allow 'line-height: 1;' line-height.patch text/plain 2965 jesse SW5kZXg6IENzc0xpbmVIZWlnaHQuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9zb3VyY2Vz L3B1YmxpYy8yMDAyL2Nzcy12YWxpZGF0b3Ivb3JnL3czYy9jc3MvcHJvcGVydGllcy9jc3MxL0Nz c0xpbmVIZWlnaHQuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMw0KZGlmZiAtdSAtcjEu MyBDc3NMaW5lSGVpZ2h0LmphdmENCi0tLSBDc3NMaW5lSGVpZ2h0LmphdmEJMTQgU2VwIDIwMDUg MTU6MTQ6MzEgLTAwMDAJMS4zDQorKysgQ3NzTGluZUhlaWdodC5qYXZhCTExIEZlYiAyMDA2IDAw OjIxOjM3IC0wMDAwDQpAQCAtMTUsNiArMTUsNyBAQA0KIGltcG9ydCBvcmcudzNjLmNzcy52YWx1 ZXMuQ3NzTnVtYmVyOw0KIGltcG9ydCBvcmcudzNjLmNzcy52YWx1ZXMuQ3NzUGVyY2VudGFnZTsN CiBpbXBvcnQgb3JnLnczYy5jc3MudmFsdWVzLkNzc1ZhbHVlOw0KK2ltcG9ydCBvcmcudzNjLmNz cy52YWx1ZXMuQ3NzVmFsdWVGbG9hdDsNCiANCiAvKioNCiAgKiAgIDxIND4NCkBAIC04Miw3ICs4 MywxMiBAQA0KIA0KIAlpZiAodmFsIGluc3RhbmNlb2YgQ3NzTnVtYmVyIHx8IHZhbCBpbnN0YW5j ZW9mIENzc0xlbmd0aCB8fA0KIAkgICAgICAgIHZhbCBpbnN0YW5jZW9mIENzc1BlcmNlbnRhZ2Up IHsNCi0JICAgIGZsb2F0IHYgPSAoKEZsb2F0KSB2YWwuZ2V0KCkpLmZsb2F0VmFsdWUoKTsNCisJ ICAgIGZsb2F0IHY7DQorCSAgICBpZiAodmFsIGluc3RhbmNlb2YgQ3NzVmFsdWVGbG9hdCkgew0K KwkgICAgCXYgPSAoKENzc1ZhbHVlRmxvYXQpdmFsKS5nZXRWYWx1ZSgpOw0KKwkgICAgfSBlbHNl IHsNCisJICAgIAl2ID0gKChGbG9hdCkgdmFsLmdldCgpKS5mbG9hdFZhbHVlKCk7DQorCSAgICB9 DQogCSAgICBpZiAodiA+PSAwKSB7DQogCQl2YWx1ZSA9IHZhbDsNCiAJCWV4cHJlc3Npb24ubmV4 dCgpOw0KSW5kZXg6IENzc0xpbmVIZWlnaHRDU1MxLmphdmENCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvc291cmNlcy9wdWJsaWMvMjAwMi9jc3MtdmFsaWRhdG9yL29yZy93M2MvY3NzL3Byb3BlcnRp ZXMvY3NzMS9Dc3NMaW5lSGVpZ2h0Q1NTMS5qYXZhLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4z DQpkaWZmIC11IC1yMS4zIENzc0xpbmVIZWlnaHRDU1MxLmphdmENCi0tLSBDc3NMaW5lSGVpZ2h0 Q1NTMS5qYXZhCTE0IFNlcCAyMDA1IDE1OjE0OjMxIC0wMDAwCTEuMw0KKysrIENzc0xpbmVIZWln aHRDU1MxLmphdmEJMTEgRmViIDIwMDYgMDA6MjE6MzggLTAwMDANCkBAIC0xNSw2ICsxNSw3IEBA DQogaW1wb3J0IG9yZy53M2MuY3NzLnZhbHVlcy5Dc3NOdW1iZXI7DQogaW1wb3J0IG9yZy53M2Mu Y3NzLnZhbHVlcy5Dc3NQZXJjZW50YWdlOw0KIGltcG9ydCBvcmcudzNjLmNzcy52YWx1ZXMuQ3Nz VmFsdWU7DQoraW1wb3J0IG9yZy53M2MuY3NzLnZhbHVlcy5Dc3NWYWx1ZUZsb2F0Ow0KIA0KIC8q Kg0KICAqICAgPEg0Pg0KQEAgLTc1LDcgKzc2LDEyIEBADQogDQogCWlmICh2YWwgaW5zdGFuY2Vv ZiBDc3NOdW1iZXIgfHwgdmFsIGluc3RhbmNlb2YgQ3NzTGVuZ3RoIHx8DQogCSAgICAgICAgdmFs IGluc3RhbmNlb2YgQ3NzUGVyY2VudGFnZSkgew0KLQkgICAgZmxvYXQgdiA9ICgoRmxvYXQpIHZh bC5nZXQoKSkuZmxvYXRWYWx1ZSgpOw0KKwkgICAgZmxvYXQgdjsNCisJICAgIGlmICh2YWwgaW5z dGFuY2VvZiBDc3NWYWx1ZUZsb2F0KSB7DQorCSAgICAJdiA9ICgoQ3NzVmFsdWVGbG9hdCl2YWwp LmdldFZhbHVlKCk7DQorCSAgICB9IGVsc2Ugew0KKwkgICAgCXYgPSAoKEZsb2F0KSB2YWwuZ2V0 KCkpLmZsb2F0VmFsdWUoKTsNCisJICAgIH0NCiAJICAgIGlmICh2ID49IDApIHsNCiAJCXZhbHVl ID0gdmFsOw0KIAkJZXhwcmVzc2lvbi5uZXh0KCk7DQpJbmRleDogQ3NzTGluZUhlaWdodENTUzIu amF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9zb3VyY2VzL3B1YmxpYy8yMDAyL2Nzcy12YWxp ZGF0b3Ivb3JnL3czYy9jc3MvcHJvcGVydGllcy9jc3MxL0Nzc0xpbmVIZWlnaHRDU1MyLmphdmEs dg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjMNCmRpZmYgLXUgLXIxLjMgQ3NzTGluZUhlaWdodENT UzIuamF2YQ0KLS0tIENzc0xpbmVIZWlnaHRDU1MyLmphdmEJMTQgU2VwIDIwMDUgMTU6MTQ6MzEg LTAwMDAJMS4zDQorKysgQ3NzTGluZUhlaWdodENTUzIuamF2YQkxMSBGZWIgMjAwNiAwMDoyMToz OCAtMDAwMA0KQEAgLTE1LDYgKzE1LDcgQEANCiBpbXBvcnQgb3JnLnczYy5jc3MudmFsdWVzLkNz c051bWJlcjsNCiBpbXBvcnQgb3JnLnczYy5jc3MudmFsdWVzLkNzc1BlcmNlbnRhZ2U7DQogaW1w b3J0IG9yZy53M2MuY3NzLnZhbHVlcy5Dc3NWYWx1ZTsNCitpbXBvcnQgb3JnLnczYy5jc3MudmFs dWVzLkNzc1ZhbHVlRmxvYXQ7DQogDQogLyoqDQogICogICA8SDQ+DQpAQCAtNzUsNyArNzYsMTIg QEANCiANCiAJaWYgKHZhbCBpbnN0YW5jZW9mIENzc051bWJlciB8fCB2YWwgaW5zdGFuY2VvZiBD c3NMZW5ndGggfHwNCiAJICAgICAgICB2YWwgaW5zdGFuY2VvZiBDc3NQZXJjZW50YWdlKSB7DQot CSAgICBmbG9hdCB2ID0gKChGbG9hdCkgdmFsLmdldCgpKS5mbG9hdFZhbHVlKCk7DQorCSAgICBm bG9hdCB2Ow0KKwkgICAgaWYgKHZhbCBpbnN0YW5jZW9mIENzc1ZhbHVlRmxvYXQpIHsNCisJICAg IAl2ID0gKChDc3NWYWx1ZUZsb2F0KXZhbCkuZ2V0VmFsdWUoKTsNCisJICAgIH0gZWxzZSB7DQor CSAgICAJdiA9ICgoRmxvYXQpIHZhbC5nZXQoKSkuZmxvYXRWYWx1ZSgpOw0KKwkgICAgfQ0KIAkg ICAgaWYgKHYgPj0gMCkgew0KIAkJdmFsdWUgPSB2YWw7DQogCQlleHByZXNzaW9uLm5leHQoKTsN Cg== 408 2006-02-16 18:48:20 +0000 2006-02-16 18:48:20 +0000 Fixes line-height: <number> line-height-2.patch text/plain 1984 jesse SW5kZXg6IENzc0xpbmVIZWlnaHQuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9zb3VyY2Vz L3B1YmxpYy8yMDAyL2Nzcy12YWxpZGF0b3Ivb3JnL3czYy9jc3MvcHJvcGVydGllcy9jc3MxL0Nz c0xpbmVIZWlnaHQuamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMw0KZGlmZiAtdSAtcjEu MyBDc3NMaW5lSGVpZ2h0LmphdmENCi0tLSBDc3NMaW5lSGVpZ2h0LmphdmEJMTQgU2VwIDIwMDUg MTU6MTQ6MzEgLTAwMDAJMS4zDQorKysgQ3NzTGluZUhlaWdodC5qYXZhCTE2IEZlYiAyMDA2IDE4 OjQyOjM5IC0wMDAwDQpAQCAtODIsNyArODIsNyBAQA0KIA0KIAlpZiAodmFsIGluc3RhbmNlb2Yg Q3NzTnVtYmVyIHx8IHZhbCBpbnN0YW5jZW9mIENzc0xlbmd0aCB8fA0KIAkgICAgICAgIHZhbCBp bnN0YW5jZW9mIENzc1BlcmNlbnRhZ2UpIHsNCi0JICAgIGZsb2F0IHYgPSAoKEZsb2F0KSB2YWwu Z2V0KCkpLmZsb2F0VmFsdWUoKTsNCisJICAgIGZsb2F0IHYgPSAoKE51bWJlcikgdmFsLmdldCgp KS5mbG9hdFZhbHVlKCk7DQogCSAgICBpZiAodiA+PSAwKSB7DQogCQl2YWx1ZSA9IHZhbDsNCiAJ CWV4cHJlc3Npb24ubmV4dCgpOw0KSW5kZXg6IENzc0xpbmVIZWlnaHRDU1MxLmphdmENCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0NClJDUyBmaWxlOiAvc291cmNlcy9wdWJsaWMvMjAwMi9jc3MtdmFsaWRhdG9yL29yZy93 M2MvY3NzL3Byb3BlcnRpZXMvY3NzMS9Dc3NMaW5lSGVpZ2h0Q1NTMS5qYXZhLHYNCnJldHJpZXZp bmcgcmV2aXNpb24gMS4zDQpkaWZmIC11IC1yMS4zIENzc0xpbmVIZWlnaHRDU1MxLmphdmENCi0t LSBDc3NMaW5lSGVpZ2h0Q1NTMS5qYXZhCTE0IFNlcCAyMDA1IDE1OjE0OjMxIC0wMDAwCTEuMw0K KysrIENzc0xpbmVIZWlnaHRDU1MxLmphdmEJMTYgRmViIDIwMDYgMTg6NDI6MzkgLTAwMDANCkBA IC03NSw3ICs3NSw3IEBADQogDQogCWlmICh2YWwgaW5zdGFuY2VvZiBDc3NOdW1iZXIgfHwgdmFs IGluc3RhbmNlb2YgQ3NzTGVuZ3RoIHx8DQogCSAgICAgICAgdmFsIGluc3RhbmNlb2YgQ3NzUGVy Y2VudGFnZSkgew0KLQkgICAgZmxvYXQgdiA9ICgoRmxvYXQpIHZhbC5nZXQoKSkuZmxvYXRWYWx1 ZSgpOw0KKwkgICAgZmxvYXQgdiA9ICgoTnVtYmVyKSB2YWwuZ2V0KCkpLmZsb2F0VmFsdWUoKTsN CiAJICAgIGlmICh2ID49IDApIHsNCiAJCXZhbHVlID0gdmFsOw0KIAkJZXhwcmVzc2lvbi5uZXh0 KCk7DQpJbmRleDogQ3NzTGluZUhlaWdodENTUzIuamF2YQ0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6 IC9zb3VyY2VzL3B1YmxpYy8yMDAyL2Nzcy12YWxpZGF0b3Ivb3JnL3czYy9jc3MvcHJvcGVydGll cy9jc3MxL0Nzc0xpbmVIZWlnaHRDU1MyLmphdmEsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjMN CmRpZmYgLXUgLXIxLjMgQ3NzTGluZUhlaWdodENTUzIuamF2YQ0KLS0tIENzc0xpbmVIZWlnaHRD U1MyLmphdmEJMTQgU2VwIDIwMDUgMTU6MTQ6MzEgLTAwMDAJMS4zDQorKysgQ3NzTGluZUhlaWdo dENTUzIuamF2YQkxNiBGZWIgMjAwNiAxODo0MjozOSAtMDAwMA0KQEAgLTc1LDcgKzc1LDcgQEAN CiANCiAJaWYgKHZhbCBpbnN0YW5jZW9mIENzc051bWJlciB8fCB2YWwgaW5zdGFuY2VvZiBDc3NM ZW5ndGggfHwNCiAJICAgICAgICB2YWwgaW5zdGFuY2VvZiBDc3NQZXJjZW50YWdlKSB7DQotCSAg ICBmbG9hdCB2ID0gKChGbG9hdCkgdmFsLmdldCgpKS5mbG9hdFZhbHVlKCk7DQorCSAgICBmbG9h dCB2ID0gKChOdW1iZXIpIHZhbC5nZXQoKSkuZmxvYXRWYWx1ZSgpOw0KIAkgICAgaWYgKHYgPj0g MCkgew0KIAkJdmFsdWUgPSB2YWw7DQogCQlleHByZXNzaW9uLm5leHQoKTsNCg==