22229 2013-05-31 11:45:47 +0000 Editorial input 2013-10-17 11:26:23 +0000 1 1 1 Unclassified WebRTC Working Group Media Capture and Streams unspecified All All RESOLVED FIXED P2 normal --- 1 stefan.lk.hakansson public-media-capture adam.bergkvist public-media-capture oldest_to_newest 88509 0 stefan.lk.hakansson 2013-05-31 11:45:47 +0000 Some minor stuff (I think it is mostly editorial): Section 3, sub section "constraints", towards the end, it is said "but ignored by the application"; should it not be "but ignored by the UA"? Section 4.1, the last four blocks of text before the figure: There is a lot of into about MediaStreamTrack's here; I think it should be moved to section 4.3. Section 4.2: It is said that "The list of MediaStream consumers currently includes the media elements and the PeerConnection API specified in [WEBRTC10].". I think we should mention MediaStream Recorder and MediaStream Image Capture as well. Section 4.2, right before the IDL: There is some reference and talking about stop() method for MediaStream, but we don't have that any more. Section 4.3, it is said taht "Note that a web application can revoke all given permissions with MediaStreamTrack.stop().". I think it should be clarified that doing .stop() on _any_ of the MediaStreamTracks served by the source would revoke the permissions. Section 4.3.1: There is a missing ")" in the text about what happens when a track ends. And I don't understand the part of the reference count. Example 2: "stream.stop();" - no stop method on MediaStream any more. 88720 1 stefan.lk.hakansson 2013-06-05 10:27:13 +0000 (In reply to comment #0) > Some minor stuff (I think it is mostly editorial): > > Section 3, sub section "constraints", towards the end, it is said "but > ignored by the application"; should it not be "but ignored by the UA"? > > Section 4.1, the last four blocks of text before the figure: There is a lot > of into about MediaStreamTrack's here; I think it should be moved to section > 4.3. > > Section 4.2: It is said that "The list of MediaStream consumers currently > includes the media elements and the PeerConnection API specified in > [WEBRTC10].". I think we should mention MediaStream Recorder and MediaStream > Image Capture as well. > > Section 4.2, right before the IDL: There is some reference and talking about > stop() method for MediaStream, but we don't have that any more. > > Section 4.3, it is said taht "Note that a web application can revoke all > given permissions with MediaStreamTrack.stop().". I think it should be > clarified that doing .stop() on _any_ of the MediaStreamTracks served by the > source would revoke the permissions. Separate bug filed for the above ("MediaStreamTrack.stop()"): https://www.w3.org/Bugs/Public/show_bug.cgi?id=22272 > > Section 4.3.1: There is a missing ")" in the text about what happens when a > track ends. And I don't understand the part of the reference count. > > Example 2: "stream.stop();" - no stop method on MediaStream any more. 94008 2 adam.bergkvist 2013-09-30 11:44:44 +0000 (In reply to Stefan Hakansson LK from comment #0) > Section 4.1, the last four blocks of text before the figure: There is a lot > of into about MediaStreamTrack's here; I think it should be moved to section > 4.3. I think it's OK to mention MediaStreamTrack in the Stream API introduction section since it talks about the Stream API in general in which MediaStreamTrack is a major component. > Section 4.3.1: There is a missing ")" in the text about what happens when a > track ends. And I don't understand the part of the reference count. The ")" is there, it's just very far away. :) Let's rewrite it and remove the "reference counting" stuff when we have resolved bug the MediaStreamTrack.stop() behavior bug (22272). 94009 3 adam.bergkvist 2013-09-30 11:48:21 +0000 Proposed fixes: https://github.com/fluffy/webrtc-w3c/commit/b2fe1848e240e7f19436918ab781664887fe0713 94886 4 adam.bergkvist 2013-10-17 11:26:23 +0000 Fixed in Editor's draft v20131017