21986 2013-05-09 15:36:58 +0000 AttrExodus: Element.attributes needs to have a named getter 2014-08-18 11:21:43 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified All All RESOLVED FIXED P2 normal --- 1 Ms2ger annevk bruant.d erik.arvidsson mike philipj www-dom public-webapps-bugzilla oldest_to_newest 87494 0 Ms2ger 2013-05-09 15:36:58 +0000 We broke this (intermittently) and got noticed: https://bugzilla.mozilla.org/show_bug.cgi?id=869796 https://bugzilla.mozilla.org/show_bug.cgi?id=868834 88418 1 annevk 2013-05-30 05:38:07 +0000 *sad panda* 90488 2 annevk 2013-07-09 15:54:28 +0000 Okay, so what interface should we introduce here? http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-1780488922 is the original solution. I called it AttrList as it's clearly not a Map in the JavaScript sense. I removed the methods that did not seem needed, but maybe they are? interface AttrList { getter Attr (DOMString name); getter Attr item(unsigned long index); unsigned long length; } I guess because of the named getter adding ArrayClass would be problematic. 90491 3 annevk 2013-07-09 16:07:20 +0000 http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozNamedAttrMap.webidl note the ? after Attr in particular. 102882 4 philipj 2014-03-25 16:56:07 +0000 If the interface needs to stay, why bother changing the name? 102883 5 annevk 2014-03-25 17:06:53 +0000 You want to keep the name NamedNodeMap from DOM Level 3 Core? 102885 6 philipj 2014-03-25 17:25:03 +0000 I don't feel strongly about it, just curious. In order to determine which bits of the API need to stay I just sent this review for more use counters in Blink: https://codereview.chromium.org/211363003 102888 7 annevk 2014-03-25 18:07:55 +0000 Mainly since if we are keeping this API around and it is being exposed to the web, we might as well try to keep it somewhat sane. 102892 8 philipj 2014-03-25 18:28:35 +0000 Unfortunately it currently doesn't seem possibly to count access to the interface object itself (e.g. using x instanceof NamedNodeMap) so I can't tell if changing it is safe. It seems fairly likely to be safe, though. Anyway, the use counters have landed now, data will show up here: NamedNodeMapGetNamedItem: http://www.chromestatus.com/metrics/feature/timeline/popularity/306 NamedNodeMapSetNamedItem: http://www.chromestatus.com/metrics/feature/timeline/popularity/307 NamedNodeMapRemoveNamedItem: http://www.chromestatus.com/metrics/feature/timeline/popularity/308 NamedNodeMapItem: http://www.chromestatus.com/metrics/feature/timeline/popularity/309 NamedNodeMapGetNamedItemNS: http://www.chromestatus.com/metrics/feature/timeline/popularity/310 NamedNodeMapSetNamedItemNS: http://www.chromestatus.com/metrics/feature/timeline/popularity/311 NamedNodeMapRemoveNamedItemNS: http://www.chromestatus.com/metrics/feature/timeline/popularity/312 110223 9 annevk 2014-08-18 11:21:43 +0000 Philip, that seems encouraging. I added get/remove as well as their NS counterparts since we are stuck with namespaced attributes I think. I did not add the methods that deal with Attr objects since those would require a link between Attr objects and elements and that would be sad as you pointed out. https://github.com/whatwg/dom/commit/8af48267390b971a2ac02c7005ba42c08264b7e1 New issues in new bugs I guess.