21931 2013-05-05 21:08:28 +0000 app/Demos/currencysvg-result.xml should not have an XML declaration. 2014-03-19 10:49:01 +0000 1 1 1 Unclassified XPath / XQuery / XSLT XQuery 3 & XPath 3 Test Suite Working drafts All All RESOLVED FIXED P2 normal --- 1 leo oneil christian.gruen mike public-qt-comments oldest_to_newest 87248 0 leo 2013-05-05 21:08:28 +0000 The documentation of `<assert-xml>` says: > Asserts the result of the query by providing a serialization of the expression > result using the default serialization parameters method="xml" indent="no" > omit-xml-declaration="yes". As the file "app/Demos/currencysvg-result.xml" has an XML declaration, I don't think the test case "currencysvg" can succeed: > <test-case name="currencysvg"> > [...] > <test file="Demos/currencysvg.xq"/> > <result> > <assert-xml file="Demos/currencysvg-result.xml"/> > </result> > </test-case> 87249 1 mike 2013-05-05 21:35:11 +0000 You're correct that the test isn't following the authoring guidelines. However, this shouldn't cause the test to fail. The documentation also states (on the "running tests" page): The assert-xml assertion succeeds if the result is an XML document that compares deep-equal to the document contained (in XML form) in the assertion. And it also says (in the schema documentation): The assertion is true if the result of parsing and canonicalizing the XML given in the body of the assert-xml element is the same (byte-for-byte) as the result of canonicalizing the XML result of the query. Clearly the presence of the XML declaration does not affect the comparison if it is done according to these rules. Assert-xml should not be interpreted as a comparison of serialized results; the schema comments make this clear. 87250 2 leo 2013-05-05 21:46:20 +0000 Correct, I misinterpreted the part saying: > The value will not necessarily be a well-formed document (it may be a fragment). > The comparison can be done by converting the string into a well-formed > document by adding a wrapper element. Doing this textually yields invalid XML if an XML declaration is present. 89170 3 oneil 2013-06-12 15:33:50 +0000 (In reply to comment #2) > Correct, I misinterpreted the part saying: > > > The value will not necessarily be a well-formed document (it may be a fragment). > > The comparison can be done by converting the string into a well-formed > > document by adding a wrapper element. > > Doing this textually yields invalid XML if an XML declaration is present. No it does not. An XML declaration is optional and if included does not count towards the well-formedness of an XML document. 89896 4 christian.gruen 2013-06-26 14:01:51 +0000 I agree with Leo that the XML declaration should be removed in this test. First, the resulting XML will indeed be invalid if the string with the XML declaration is converted "into a well-formed document by adding a wrapper element.", as proposed in the documentation. Second, it seems to be the only test case that does not follow the authoring guidelines, so it’s probably less effort than aligning the documentation. 90117 5 oneil 2013-07-02 15:47:23 +0000 I withdraw my comment in #3. If we all agree I will will remove the XML declaration 90120 6 leo 2013-07-02 16:19:10 +0000 That would be great. 102625 7 oneil 2014-03-19 10:49:01 +0000 Bug fixed and committed to cvs