21240 2013-03-10 17:10:27 +0000 Specify what should happen when passing invalid offset/duration values to AudioBufferSourceNode.start 2014-10-28 17:16:26 +0000 1 1 1 Unclassified AudioWG Web Audio API unspecified PC All CLOSED WONTFIX P2 normal TBD 1 ehsan crogers joe roc public-audio oldest_to_newest 84202 0 1331 ehsan 2013-03-10 17:10:27 +0000 Created attachment 1331 Test case We need to specify what happens when these values are invalid, for example, negative, or greater than the length of the buffer. Currently, WebKit ignores offset if it's negative but smaller than the length of the buffer, and in that case respects duration. If a value larger than the length of the buffer is passed as offset, then WebKit ignores both offset and duration. It would have probably made much more sense if these kinds of invalid values would throw DOM_SYNTAX_ERR as these are probably not what the author would intend to pass in. 84203 1 ehsan 2013-03-10 17:49:15 +0000 The same kind of problem seems to apply to loopStart as well. 84206 2 roc 2013-03-10 21:26:13 +0000 I don't think throwing an exception is necessary here. I don't like the behavior of just ignoring the offset if it's >= the length of the buffer. That creates a discontinuity as the offset increases from before the buffer end to after it. If compatibility issues don't trump, then I suggest first clamping the offset to [0, length], then adding the duration to find the endpoint and clamping the endpoint. 87243 3 ehsan 2013-05-04 15:28:51 +0000 Chris, what do you think the right behavior here should be? 92269 4 joe 2013-08-19 14:40:14 +0000 Also note bug 23007. If we accept that the duration value is shorthand for calling stop() at a specified temporal offset, then this bug goes away (or should be recast in terms of asking stop() to throw exceptions for invalid time offsets, etc.) 113845 5 olivier.thereaux 2014-10-28 17:13:30 +0000 Web Audio API issues have been migrated to Github. See https://github.com/WebAudio/web-audio-api/issues 113988 6 olivier.thereaux 2014-10-28 17:16:26 +0000 Closing. See https://github.com/WebAudio/web-audio-api/issues for up to date list of issues for the Web Audio API. 1331 2013-03-10 17:10:27 +0000 2013-03-10 17:10:27 +0000 Test case negativeoffset.html text/html 871 ehsan PCFET0NUWVBFIEhUTUw+DQo8Ym9keT4NCjxzY3JpcHQ+DQp2YXIgVCA9IDAuNTsNCnRyeSB7DQog IHZhciBjdHggPSBuZXcgQXVkaW9Db250ZXh0KCk7DQp9IGNhdGNoIChlKSB7DQogIGN0eCA9IG5l dyB3ZWJraXRBdWRpb0NvbnRleHQoKTsNCn0NCnZhciBidWZmZXJzID0gW107DQpmb3IgKHZhciBp ID0gMDsgaSA8IDE7ICsraSkgew0KICB2YXIgY2hhbm5lbHMgPSAxOw0KICB2YXIgYnVmZmVyID0g Y3R4LmNyZWF0ZUJ1ZmZlcihjaGFubmVscywgVCpjdHguc2FtcGxlUmF0ZSwgY3R4LnNhbXBsZVJh dGUpOw0KICB2YXIgZiA9IDMwMDAgKyAoaSoxMDApOw0KICBmb3IgKHZhciBqID0gMDsgaiA8IGJ1 ZmZlci5sZW5ndGg7ICsraikgew0KICAgIHZhciBzYW1wbGUgPSBNYXRoLnNpbigoai9jdHguc2Ft cGxlUmF0ZSkqTWF0aC5QSSoyKmYpOw0KCWZvciAodmFyIGMgPSAwOyBjIDwgY2hhbm5lbHM7ICsr Yykgew0KICAgICAgYnVmZmVyLmdldENoYW5uZWxEYXRhKGMpW2pdID0gc2FtcGxlOw0KCX0NCiAg fQ0KICBidWZmZXJzW2ldID0gYnVmZmVyOw0KfQ0KDQpmdW5jdGlvbiBwbGF5KG9mZnNldCwgZHVy YXRpb24pIHsNCiAgZm9yICh2YXIgaSA9IDA7IGkgPCAxOyArK2kpIHsNCiAgICB2YXIgbm9kZSA9 IGN0eC5jcmVhdGVCdWZmZXJTb3VyY2UoKTsNCiAgICBub2RlLmJ1ZmZlciA9IGJ1ZmZlcnNbaSVi dWZmZXJzLmxlbmd0aF07DQogICAgbm9kZS5zdGFydChpKlQvMiwgb2Zmc2V0LCBkdXJhdGlvbik7 DQogICAgbm9kZS5jb25uZWN0KGN0eC5kZXN0aW5hdGlvbik7DQogIH0NCn0NCg0KcGxheSgtVCwg VC8yKTsNCnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7DQogIHBsYXkoMipULCBULzIpOw0KfSwgMzAw MCk7DQo8L3NjcmlwdD4NCg==