21223 2013-03-08 16:55:21 +0000 Mandate a useful accepted sampling rate ranges for buffers created through AudioContext.createBuffer 2014-10-28 17:17:39 +0000 1 1 1 Unclassified AudioWG Web Audio API unspecified PC All CLOSED WONTFIX P2 normal TBD 1 ehsan ehsan giles mtanalin olivier.thereaux public-audio oldest_to_newest 84120 0 ehsan 2013-03-08 16:55:21 +0000 Currently, the spec just suggests that implementations should at least accept sampling rate ranges of 22050-96000. I think it would be better to mandate this range as opposed to just suggest it, since otherwise it would be possible to write code which works in one UA and not the other. Also, sampling rates outside of this range probably don't make much sense anyway. 84121 1 ehsan 2013-03-08 16:57:11 +0000 Paul Adenot brought up a very good point in <https://bugzilla.mozilla.org/show_bug.cgi?id=849230#c1>. We should consider setting the minimum sample rate value to 8000Hz. 84122 2 ehsan 2013-03-08 16:59:45 +0000 Also, the spec doesn't specify what needs to happen if the sample rate is not accepted, as usual. ;) WebKit throws DOM_SYNTAX_ERR, I'm going to modify Gecko to do the same. We should spec this. 84134 3 giles 2013-03-08 21:20:20 +0000 96 kHz is an odd limit, considering the fad for material at 192 kHz. I think the allowed range should be either 8-48 kHz or 8-192 kHz. 84135 4 crogers 2013-03-08 21:33:37 +0000 (In reply to comment #3) > 96 kHz is an odd limit, considering the fad for material at 192 kHz. I think > the allowed range should be either 8-48 kHz or 8-192 kHz. 8-192 KHz sounds good to me 84137 5 ehsan 2013-03-08 21:39:09 +0000 (In reply to comment #4) > (In reply to comment #3) > > 96 kHz is an odd limit, considering the fad for material at 192 kHz. I think > > the allowed range should be either 8-48 kHz or 8-192 kHz. > > 8-192 KHz sounds good to me Sounds good to me too! 84200 6 mtanalin 2013-03-10 16:37:32 +0000 "At least" should not be confused with "limited to". These are totally different things. Current spec says "must", not "should": "An implementation must support sample-rates in at least the range 22050 to 96000." (https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#dfn-sampleRate_2) That does require that the range of sample rates must be supported, but does not prevent implementations from supporting more wide range if they want / need / are able to. There is no sense to _limit_ sample-rate range unless there are corresponding technical limitations in a specific implementation. This is completely out of the spec scope. 84220 7 olivier.thereaux 2013-03-11 11:43:28 +0000 The spec currently says two things: * An implementation must support sample-rates in at least the range 22050 to 96000. * An exception will be thrown if the numberOfChannels or sampleRate are out-of-bounds Looking at the discussion so far, I think the spec should say something like: * implementations MUST support sampling rate ranges of 8-192 KHz. sampling rates beyond this range MAY be supported. * [in The createBuffer method ] An exception MUST be thrown if sampleRate is out of bounds. is DOM_SYNTAX_ERR the best exception though? 84224 8 ehsan 2013-03-11 15:12:34 +0000 (In reply to comment #7) > The spec currently says two things: > * An implementation must support sample-rates in at least the range 22050 to > 96000. > * An exception will be thrown if the numberOfChannels or sampleRate are > out-of-bounds > > > Looking at the discussion so far, I think the spec should say something like: > > * implementations MUST support sampling rate ranges of 8-192 KHz. sampling > rates beyond this range MAY be supported. > * [in The createBuffer method ] An exception MUST be thrown if sampleRate is > out of bounds. That sounds fine. > is DOM_SYNTAX_ERR the best exception though? Not really. The best exception for this kind of error would be INDEX_SIZE_ERR, I think, since that is supposed to be used for out of range arguments <http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-17189187>. 84337 9 olivier.thereaux 2013-03-13 14:50:31 +0000 Seeing as we seem to have consensus on the solution, I am setting the issue as ASSIGNED (to CRogers - although others are welcome to send a patch to the source of the spec in dvcs.w3.org). 84339 10 1336 ehsan 2013-03-13 15:07:04 +0000 Created attachment 1336 Patch Does this look good? 84340 11 1337 ehsan 2013-03-13 15:08:44 +0000 Created attachment 1337 Patch Actually this is probably better! 84426 12 olivier.thereaux 2013-03-14 16:45:19 +0000 (In reply to comment #11) > Created attachment 1337 [details] > Patch > > Actually this is probably better! Ehsan, we discussed this - good to go, please push to the repo. 113948 13 olivier.thereaux 2014-10-28 17:14:42 +0000 Web Audio API issues have been migrated to Github. See https://github.com/WebAudio/web-audio-api/issues 114097 14 olivier.thereaux 2014-10-28 17:17:39 +0000 Closing. See https://github.com/WebAudio/web-audio-api/issues for up to date list of issues for the Web Audio API. 1336 2013-03-13 15:07:04 +0000 2013-03-13 15:08:44 +0000 Patch x text/plain 1562 ehsan ZGlmZiAtLWdpdCBhL3dlYmF1ZGlvL3NwZWNpZmljYXRpb24uaHRtbCBiL3dlYmF1ZGlvL3NwZWNp ZmljYXRpb24uaHRtbAotLS0gYS93ZWJhdWRpby9zcGVjaWZpY2F0aW9uLmh0bWwKKysrIGIvd2Vi YXVkaW8vc3BlY2lmaWNhdGlvbi5odG1sCkBAIC05MTcsMTcgKzkxNywxOCBAQCBpbnRlcmZhY2Ug PGRmbiBpZD0iZGZuLUF1ZGlvQ29udGV4dCI+QXVkCiAgICAgICBidWZmZXIgd2lsbCBiZSB6ZXJv LWluaXRpYWxpemVkIChzaWxlbnQpLiAgQW4gZXhjZXB0aW9uIHdpbGwgYmUgdGhyb3duIGlmCiAg ICAgICB0aGUgPGNvZGU+bnVtYmVyT2ZDaGFubmVsczwvY29kZT4gb3IgPGNvZGU+c2FtcGxlUmF0 ZTwvY29kZT4gYXJlIG91dC1vZi1ib3VuZHMuPC9wPgogICAgICAgPHA+VGhlIDxkZm4gaWQ9ImRm bi1udW1iZXJPZkNoYW5uZWxzIj5udW1iZXJPZkNoYW5uZWxzPC9kZm4+IHBhcmFtZXRlcgogICAg ICAgZGV0ZXJtaW5lcyBob3cgbWFueSBjaGFubmVscyB0aGUgYnVmZmVyIHdpbGwgaGF2ZS4gIEFu IGltcGxlbWVudGF0aW9uIG11c3Qgc3VwcG9ydCBhdCBsZWFzdCAzMiBjaGFubmVscy4gPC9wPgog ICAgICAgPHA+VGhlIDxkZm4gaWQ9ImRmbi1sZW5ndGgiPmxlbmd0aDwvZGZuPiBwYXJhbWV0ZXIg ZGV0ZXJtaW5lcyB0aGUgc2l6ZSBvZgogICAgICAgdGhlIGJ1ZmZlciBpbiBzYW1wbGUtZnJhbWVz LiA8L3A+CiAgICAgICA8cD5UaGUgPGRmbiBpZD0iZGZuLXNhbXBsZVJhdGVfMiI+c2FtcGxlUmF0 ZTwvZGZuPiBwYXJhbWV0ZXIgZGVzY3JpYmVzCiAgICAgICB0aGUgc2FtcGxlLXJhdGUgb2YgdGhl IGxpbmVhciBQQ00gYXVkaW8gZGF0YSBpbiB0aGUgYnVmZmVyIGluCi0gICAgICBzYW1wbGUtZnJh bWVzIHBlciBzZWNvbmQuICBBbiBpbXBsZW1lbnRhdGlvbiBtdXN0IHN1cHBvcnQgc2FtcGxlLXJh dGVzIGluIGF0IGxlYXN0IHRoZSByYW5nZSAyMjA1MCB0byA5NjAwMC48L3A+CisgICAgICBzYW1w bGUtZnJhbWVzIHBlciBzZWNvbmQuICBBbiBpbXBsZW1lbnRhdGlvbiBNVVNUIHN1cHBvcnQgc2Ft cGxlLXJhdGVzIGluIGF0IGxlYXN0IHRoZSByYW5nZSA4MDAwIHRvIDE5MjAwMC4KKyAgICAgIElm IGFuIG91dC1vZi1ib3VuZHMgc2FtcGxlLXJhdGUgaXMgcGFzc2VkIGluLCBhbiBJTkRFWF9TSVpF X0VSUiBleGNlcHRpb24gTVVTVCBiZSB0aHJvd24uPC9wPgogICAgIDwvZGQ+CiA8L2RsPgogPGRs PgogICA8ZHQgaWQ9ImRmbi1jcmVhdGVCdWZmZXJfMiI+VGhlIDxjb2RlPmNyZWF0ZUJ1ZmZlcjwv Y29kZT4gZnJvbSBBcnJheUJ1ZmZlcgogICBtZXRob2Q8L2R0PgogICAgIDxkZD48cD5DcmVhdGVz IGFuIEF1ZGlvQnVmZmVyIGdpdmVuIHRoZSBhdWRpbyBmaWxlIGRhdGEgY29udGFpbmVkIGluIHRo ZQogICAgICAgQXJyYXlCdWZmZXIuIFRoZSBBcnJheUJ1ZmZlciBjYW4sIGZvciBleGFtcGxlLCBi ZSBsb2FkZWQgZnJvbSBhbiBYTUxIdHRwUmVxdWVzdCdzCiAgICAgICAgIDxjb2RlPnJlc3BvbnNl PC9jb2RlPiBhdHRyaWJ1dGUgYWZ0ZXIgc2V0dGluZyB0aGUgPGNvZGU+cmVzcG9uc2VUeXBlPC9j b2RlPiB0byAiYXJyYXlidWZmZXIiLgo= 1337 2013-03-13 15:08:44 +0000 2013-03-13 15:08:44 +0000 Patch x text/plain 1872 ehsan ZGlmZiAtLWdpdCBhL3dlYmF1ZGlvL3NwZWNpZmljYXRpb24uaHRtbCBiL3dlYmF1ZGlvL3NwZWNp ZmljYXRpb24uaHRtbAotLS0gYS93ZWJhdWRpby9zcGVjaWZpY2F0aW9uLmh0bWwKKysrIGIvd2Vi YXVkaW8vc3BlY2lmaWNhdGlvbi5odG1sCkBAIC05MDksMjUgKzkwOSwyNSBAQCBpbnRlcmZhY2Ug PGRmbiBpZD0iZGZuLUF1ZGlvQ29udGV4dCI+QXVkCiA8L2RsPgogPC9kaXY+CiAKIDxkaXYgaWQ9 Im1ldGhvZHNhbmRwYXJhbXMtQXVkaW9Db250ZXh0LXNlY3Rpb24iIGNsYXNzPSJzZWN0aW9uIj4K IDxoMyBpZD0ibWV0aG9kc2FuZHBhcmFtcy1BdWRpb0NvbnRleHQiPjQuMS4yLiBNZXRob2RzIGFu ZCBQYXJhbWV0ZXJzPC9oMz4KIDxkbD4KICAgPGR0IGlkPSJkZm4tY3JlYXRlQnVmZmVyIj5UaGUg PGNvZGU+Y3JlYXRlQnVmZmVyPC9jb2RlPiBtZXRob2Q8L2R0PgogICAgIDxkZD48cD5DcmVhdGVz IGFuIEF1ZGlvQnVmZmVyIG9mIHRoZSBnaXZlbiBzaXplLiBUaGUgYXVkaW8gZGF0YSBpbiB0aGUK LSAgICAgIGJ1ZmZlciB3aWxsIGJlIHplcm8taW5pdGlhbGl6ZWQgKHNpbGVudCkuICBBbiBleGNl cHRpb24gd2lsbCBiZSB0aHJvd24gaWYKKyAgICAgIGJ1ZmZlciB3aWxsIGJlIHplcm8taW5pdGlh bGl6ZWQgKHNpbGVudCkuICBBbiBJTkRFWF9TSVpFX0VSUiBleGNlcHRpb24gTVVTVCBiZSB0aHJv d24gaWYKICAgICAgIHRoZSA8Y29kZT5udW1iZXJPZkNoYW5uZWxzPC9jb2RlPiBvciA8Y29kZT5z YW1wbGVSYXRlPC9jb2RlPiBhcmUgb3V0LW9mLWJvdW5kcy48L3A+CiAgICAgICA8cD5UaGUgPGRm biBpZD0iZGZuLW51bWJlck9mQ2hhbm5lbHMiPm51bWJlck9mQ2hhbm5lbHM8L2Rmbj4gcGFyYW1l dGVyCiAgICAgICBkZXRlcm1pbmVzIGhvdyBtYW55IGNoYW5uZWxzIHRoZSBidWZmZXIgd2lsbCBo YXZlLiAgQW4gaW1wbGVtZW50YXRpb24gbXVzdCBzdXBwb3J0IGF0IGxlYXN0IDMyIGNoYW5uZWxz LiA8L3A+CiAgICAgICA8cD5UaGUgPGRmbiBpZD0iZGZuLWxlbmd0aCI+bGVuZ3RoPC9kZm4+IHBh cmFtZXRlciBkZXRlcm1pbmVzIHRoZSBzaXplIG9mCiAgICAgICB0aGUgYnVmZmVyIGluIHNhbXBs ZS1mcmFtZXMuIDwvcD4KICAgICAgIDxwPlRoZSA8ZGZuIGlkPSJkZm4tc2FtcGxlUmF0ZV8yIj5z YW1wbGVSYXRlPC9kZm4+IHBhcmFtZXRlciBkZXNjcmliZXMKICAgICAgIHRoZSBzYW1wbGUtcmF0 ZSBvZiB0aGUgbGluZWFyIFBDTSBhdWRpbyBkYXRhIGluIHRoZSBidWZmZXIgaW4KLSAgICAgIHNh bXBsZS1mcmFtZXMgcGVyIHNlY29uZC4gIEFuIGltcGxlbWVudGF0aW9uIG11c3Qgc3VwcG9ydCBz YW1wbGUtcmF0ZXMgaW4gYXQgbGVhc3QgdGhlIHJhbmdlIDIyMDUwIHRvIDk2MDAwLjwvcD4KKyAg ICAgIHNhbXBsZS1mcmFtZXMgcGVyIHNlY29uZC4gIEFuIGltcGxlbWVudGF0aW9uIE1VU1Qgc3Vw cG9ydCBzYW1wbGUtcmF0ZXMgaW4gYXQgbGVhc3QgdGhlIHJhbmdlIDgwMDAgdG8gMTkyMDAwLjwv cD4KICAgICA8L2RkPgogPC9kbD4KIDxkbD4KICAgPGR0IGlkPSJkZm4tY3JlYXRlQnVmZmVyXzIi PlRoZSA8Y29kZT5jcmVhdGVCdWZmZXI8L2NvZGU+IGZyb20gQXJyYXlCdWZmZXIKICAgbWV0aG9k PC9kdD4KICAgICA8ZGQ+PHA+Q3JlYXRlcyBhbiBBdWRpb0J1ZmZlciBnaXZlbiB0aGUgYXVkaW8g ZmlsZSBkYXRhIGNvbnRhaW5lZCBpbiB0aGUKICAgICAgIEFycmF5QnVmZmVyLiBUaGUgQXJyYXlC dWZmZXIgY2FuLCBmb3IgZXhhbXBsZSwgYmUgbG9hZGVkIGZyb20gYW4gWE1MSHR0cFJlcXVlc3Qn cwogICAgICAgICA8Y29kZT5yZXNwb25zZTwvY29kZT4gYXR0cmlidXRlIGFmdGVyIHNldHRpbmcg dGhlIDxjb2RlPnJlc3BvbnNlVHlwZTwvY29kZT4gdG8gImFycmF5YnVmZmVyIi4K