21159 2013-02-28 21:50:07 +0000 SourceBuffer appendArrayBuffer should take ArrayBufferView 2013-03-05 17:27:52 +0000 1 1 1 Unclassified HTML WG Media Source Extensions unspecified PC All RESOLVED FIXED P2 normal --- 1 watsonm acolwell acolwell adrianba mhakobyan mike public-html-media public-html-bugzilla oldest_to_newest 83842 0 watsonm 2013-02-28 21:50:07 +0000 Presently the SourceBuffer appendArrayBuffer method takes an ArrayBuffer argument, meaning that there is an additional copy whenever the data to be appended is not already in a single ArrayBuffer object (for example if only part of an ArrayBuffer received from XmlHttpRequest is to be appended). Consider changing this to ArrayBufferView, so that view objects like Uint8Arrays can be appended (as in the original webkitSourceAppend). 83947 1 acolwell 2013-03-04 17:38:14 +0000 Any preference on the method name? 1. Keep as appendArrayBuffer() 2. Change to appendArrayBufferView() 3. Change to appendBuffer() 4. Other suggestions welcome. 83955 2 adrianba 2013-03-04 19:37:20 +0000 I think the method can be overloaded to accept either an ArrayBuffer or ArrayBufferView. This is what we've done elsewhere in the platform. I'm not precious about the naming but prefer to settle on something sooner rather than later if we're going to make a change. 83960 3 acolwell 2013-03-04 20:04:54 +0000 (In reply to comment #2) > I think the method can be overloaded to accept either an ArrayBuffer or > ArrayBufferView. This is what we've done elsewhere in the platform. > > I'm not precious about the naming but prefer to settle on something sooner > rather than later if we're going to make a change. Ok. How about we just call it appendBuffer() and I'll add the 2 overloads. void appendBuffer(ArrayBuffer) void appendBuffer(ArrayBufferView) That way if we come across some other buffer type we need to add, we can just add the extra overload w/o changing the method name. 84000 4 acolwell 2013-03-05 17:27:52 +0000 Changes committed. https://dvcs.w3.org/hg/html-media/rev/dcd406812201