21069 2013-02-21 11:23:06 +0000 [Unforgeable] attributes as data property 2013-02-21 13:55:13 +0000 1 1 1 Unclassified WebAppsWG WebIDL unspecified PC Linux RESOLVED INVALID P2 normal --- 1 bruant.d cam annevk bzbarsky mike public-script-coord public-webapps-bugzilla oldest_to_newest 83478 0 bruant.d 2013-02-21 11:23:06 +0000 Per bug 21068, event.isTrusted is now [Unforgeable], so the 'isTrusted' property is now own and not inherited. One question which answer is not fully clear to me is: should there be one getter per event instance or one getter shared by all event instances? A way to not have to answer this question is just to make [Unforgeable] attributes data properties instead of getters. 83479 1 annevk 2013-02-21 11:31:43 +0000 Also, if all attributes that are unforgeable are readonly (and it looks like it) maybe we should support this is unforgeable attribute ...; instead? 83480 2 bruant.d 2013-02-21 11:37:19 +0000 (In reply to comment #1) > Also, if all attributes that are unforgeable are readonly (and it looks like > it) maybe we should support this is > > unforgeable attribute ...; > > instead? First line of the definition of [Unforgeable]: "If the [Unforgeable] extended attribute appears on a read only attribute...", so I guess it means it can only happen to read only attributes... The only places I know of unforgeable properties are: * http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#the-window-object * http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#document * and now event.isTrusted And indeed, it only applies to readonly. So it probably is a nice refactoring. 83482 3 bzbarsky 2013-02-21 13:33:27 +0000 In Gecko's implementation there is a separate getter per object instance for unforgeable attributes. Making this a data property is not an option, imo: it needs to be non-configurable and readonly but the boolean returned can change. 83483 4 annevk 2013-02-21 13:41:12 +0000 Ah yeah, the value of isTrusted can change over time. (I should probably learn about data properties at some point.) 83484 5 bruant.d 2013-02-21 13:46:43 +0000 (In reply to comment #4) > Ah yeah, the value of isTrusted can change over time. In what circumstances? > (I should probably > learn about data properties at some point.) I think this particular section will tell you all you need to know: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/defineProperty#Description (I plan to move the property descriptor material to its own page eventually instead of having it explained in Object.defineProperty) 83485 6 annevk 2013-02-21 13:53:19 +0000 Put a trusted event object in a variable and then dispatch it. isTrusted will have changed per http://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent for hopefully obvious reasons. 83486 7 bruant.d 2013-02-21 13:55:13 +0000 (In reply to comment #6) > Put a trusted event object in a variable and then dispatch it. isTrusted > will have changed per > http://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent for hopefully > obvious reasons. Yes, ok. Taking back the data property idea, then.