20674 2013-01-15 15:40:41 +0000 [XT3TS] result-document-0202 and others 2013-01-22 09:42:24 +0000 1 1 1 Unclassified XPath / XQuery / XSLT XSLT 3.0 Test Suite Working drafts PC Windows NT CLOSED WORKSFORME P2 normal --- 1 tim abel.online mike public-qt-comments oldest_to_newest 81399 0 tim 2013-01-15 15:40:41 +0000 The following tests have serializations which use '\n' as the newline character. Elsewhere in the test suite, the newline characters used is '\r\n'. output-0201 output-0202 output-0203 output-0205 output-0206 result-document-0202 81409 1 mike 2013-01-15 17:29:00 +0000 Couldn't we simply say that assert-serialization normalizes newlines before comparison? 81441 2 tim 2013-01-15 22:05:11 +0000 We do byte-by-byte comparison of the serialised result against the expected result. To get around the problem, we serialise the result both with \n and \r\n and try the comparison with each. Is it safe to replace a 13 10 byte sequence with 10 without reference to the text encoding, or would we have to use the output encoding to decode the byte stream, do the character replacement, then re-encode to a byte stream? 81442 3 mike 2013-01-15 22:15:43 +0000 I don't think we yet have mechanisms to make assertions against the binary encoding of the serialized output (though I remember thinking about how to do it). I think that the assert-serialization assertion is comparing characters, not bytes, and relies on you either (a) capturing the characters before they are encoded, or (b) decoding the binary serialization back to characters. So you should be able to normalize line endings at the character level. 81471 4 tim 2013-01-16 14:04:50 +0000 What I'm currently doing works well enough, but most tests appear to have been encoded with \r\n, so I presumed it was intended to be consistent. If I remember correctly, CVS sorts this out automagically. Presumably mercurial doesn't. I only recently switched to comparing the bytes, and can't quite remember why I made the change - I'll check my SVN logs to find out why. BTW, there are broken links and requests for authentication for some links in the documentation at: http://dev.w3.org/2011/QT3-test-suite/guide/running.html 3.g. http://dev.w3.org/2011/QT3-test-suite/guide/catalog-schema.html 81472 5 tim 2013-01-16 14:05:57 +0000 Would you have any objection to me making them consistent? 81478 6 mike 2013-01-16 14:19:09 +0000 No, go ahead and fix them.