20381 2012-12-13 19:20:54 +0000 MIDIInput and MIDIOutput should inherit from MIDIPort, which should not be an interface 2013-01-18 15:51:02 +0000 1 1 1 Unclassified AudioWG MIDI API unspecified All All CLOSED FIXED P2 normal TBD 1 cwilso cwilso public-audio oldest_to_newest 80122 0 cwilso 2012-12-13 19:20:54 +0000 From Marcos: It would be better if you could fold everything into MIDIPort and get rid of MIDIOutput and MIDIInput? you already have the port type, and you can just say that sending() does nothing when a port is not outputting. If you don't agree, then I think MIDIInput and MIDIOutput need to inherit from MIDIPort (not implement the interface). Implementing the interface makes a huge mess when actually implementing, as the stuff from MIDIPort has to be copied over from MIDIPort. So, worst case, please change the spec to match the following pattern: interface MIDIOutput : MIDIPort { } interface MIDIInput : MIDIPort { } MIDIPort : EventTarget{ } However, I strongly urge you to do away with MIDIInput and MIDIOutput. They are redundant, IMHO. 80123 1 cwilso 2012-12-13 19:21:37 +0000 I'll restructure. They are not redundant, though - Input and Output ports are very different, and not interchangeable. 80149 2 cwilso 2012-12-13 21:16:31 +0000 Forgot this bit of feedback to roll together: The following is also incorrect: [TreatNonCallableAsNull] attribute callback? onmessage; Please change it to: attribute EventHandler onmessage; Fixed all these issues: https://dvcs.w3.org/hg/audio/rev/477c4b064f31 81579 3 olivier.thereaux 2013-01-18 15:51:02 +0000 Batch-closing RESOLVED MIDI issues. Reminder: midi issues now tracked at https://github.com/WebAudio/web-midi-api/issues