20364 2012-12-12 21:24:01 +0000 Interface feedback 2013-01-02 11:32:33 +0000 1 1 1 Unclassified AudioWG MIDI API unspecified All All CLOSED FIXED P2 normal TBD 1 cwilso cwilso jussi.kalliokoski olivier.thereaux w3c public-audio oldest_to_newest 80034 0 cwilso 2012-12-12 21:24:01 +0000 From Marcos Caceres (marcos@marcosc.com) The following is not defined correctly: [NoInterfaceObject] interface NavigatorMIDIAccess { void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, optional NavigatorMIDIAccessErrorCallback? errorCallback); }; Should just be: partial interface Navigator { void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, optional NavigatorMIDIAccessErrorCallback? errorCallback); }; Bikeshed: NavigatorMIDIAccessSuccessCallback is a little excessive :) Just called them "successcb" and "failcb". They are just functions without a "real" interface, so no need to go all camel case there :) Also, MIDIPort should not be a [NoInterfaceObject]. Either fold it into MIDIOutput or make it into a partial interface. Generally speaking, don't make things [NoInterfaceObject]. WebIDL says not to do that unless its for Legacy reasons: [[ Warning The [NoInterfaceObject] (http://www.w3.org/TR/WebIDL/#NoInterfaceObject) extended attribute should not be used on interfaces that are not solely used as supplemental (http://www.w3.org/TR/WebIDL/#dfn-supplemental-interface) interfaces, unless there are clear Web compatibility reasons for doing so. Specification authors who wish to use this feature are strongly advised to discuss this on the public-script-coord@w3.org (mailto:public-script-coord@w3.org) mailing list before proceeding. ]] Also applied to MIDIEvent. 80103 1 jussi.kalliokoski 2012-12-13 15:31:59 +0000 (In reply to comment #0) > From Marcos Caceres (marcos@marcosc.com) > > The following is not defined correctly: > > [NoInterfaceObject] > interface NavigatorMIDIAccess { > void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, > optional NavigatorMIDIAccessErrorCallback? errorCallback); > > }; > > > Should just be: > > partial interface Navigator { > void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, > optional NavigatorMIDIAccessErrorCallback? errorCallback); > }; > Not fixed yet. > > > Bikeshed: NavigatorMIDIAccessSuccessCallback is a little excessive :) Just > called them "successcb" and "failcb". They are just functions without a > "real" interface, so no need to go all camel case there :) Fixed: https://dvcs.w3.org/hg/audio/rev/bf4f6fd3ecef > Also, MIDIPort should not be a [NoInterfaceObject]. Either fold it into > MIDIOutput or make it into a partial interface. > > Generally speaking, don't make things [NoInterfaceObject]. WebIDL says not > to do that unless its for Legacy reasons: > > [[ > Warning > > The [NoInterfaceObject] (http://www.w3.org/TR/WebIDL/#NoInterfaceObject) > extended attribute should not be used on interfaces that are not solely used > as supplemental (http://www.w3.org/TR/WebIDL/#dfn-supplemental-interface) > interfaces, unless there are clear Web compatibility reasons for doing so. > Specification authors who wish to use this feature are strongly advised to > discuss this on the public-script-coord@w3.org > (mailto:public-script-coord@w3.org) mailing list before proceeding. > ]] > > Also applied to MIDIEvent. Fixed: https://dvcs.w3.org/hg/audio/rev/bf4f6fd3ecef 80111 2 jussi.kalliokoski 2012-12-13 16:21:16 +0000 (In reply to comment #0) > From Marcos Caceres (marcos@marcosc.com) > > The following is not defined correctly: > > [NoInterfaceObject] > interface NavigatorMIDIAccess { > void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, > optional NavigatorMIDIAccessErrorCallback? errorCallback); > > }; > > > Should just be: > > partial interface Navigator { > void getMIDIAccess (NavigatorMIDIAccessSuccessCallback successCallback, > optional NavigatorMIDIAccessErrorCallback? errorCallback); > }; Fixed: https://dvcs.w3.org/hg/audio/rev/ddd6455eebf6 80126 3 cwilso 2012-12-13 19:27:32 +0000 All issues represented here have been fixed. 80823 4 olivier.thereaux 2013-01-02 11:32:33 +0000 The two changesets look good. https://dvcs.w3.org/hg/audio/rev/bf4f6fd3ecef https://dvcs.w3.org/hg/audio/rev/ddd6455eebf6 Closing.