20104 2012-11-27 18:35:31 +0000 Algorithm for DOMTokenList.add seems wrong if tokens are present multiple times in the list 2012-12-04 15:55:21 +0000 1 1 1 Unclassified WebAppsWG DOM unspecified PC Windows 3.1 RESOLVED FIXED P2 normal --- 1 bzbarsky annevk bugs erik.arvidsson ian james jonas mike ojan www-dom zcorpan public-webapps-bugzilla oldest_to_newest 78935 0 bzbarsky 2012-11-27 18:35:31 +0000 Consider this script: var d = document.createElement("div"); d.classList.add("a", "a"); If I read the spec right, the result of this will serialize as: <div class="a a"></div> which seems slightly odd. 78938 1 annevk 2012-11-27 18:43:11 +0000 Do we want to catch this? Is the extra validation step negligible? 78947 2 bzbarsky 2012-11-27 19:29:18 +0000 I don't know. None of this stuff is exactly super-fast, as currently specced. How UAs optimize it is an interesting question; Gecko doesn't try very hard at the moment afaict, though I might change that. One related question is whether we want: d.classList.add.apply(d.classList, args); to have different behavior from: args.map(function(x) { d.classList.add(x); }); and in general what invariants we want this token list stuff to preserve. 78974 3 jonas 2012-11-28 04:15:26 +0000 Optimizing the existing stuff for performance seems better to me than slowing things down even more. I don't have any concrete suggestions though. 78987 4 annevk 2012-11-28 11:40:51 +0000 Would there be a problem with changing the model of DOMTokenList to an ordered set instead? The moment you start modifying class="" through DOMTokenList, class="" would simply become a simple serialization of DOMTokenList rather than preserving all the things it tries to do now. 79025 5 erik.arvidsson 2012-11-28 18:44:53 +0000 The whole idea of trying to preserve the whitespaces of the class attribute when we mutate the DOMTokenList is something that has been bothered all along. Let's remove duplicates and simply serialize by adding a space between each token. This is what JS libs did for years and polyfills still do so it should be safe. 79033 6 annevk 2012-11-28 19:35:03 +0000 The following is my plan: DOMTokenList represents an ordered set (with set guaranteeing uniqueness, of course). Manipulating its associated attribute (e.g. class="") seeds DOMTokenList. Manipulating DOMTokenList seeds its associated attribute (a simple serialization of the ordered set, tokens separated by U+0020). Somehow we avoid loops. DOMSettableTokenList does the same. 79125 7 bugs 2012-11-29 15:15:58 +0000 To have sane toggle handling we need to remove duplicates. 79408 8 annevk 2012-12-04 15:55:21 +0000 DOMTokenList is now defined as representing an ordered set. See bug 20105 for how that serializes to a string and parses from a string.